From: Eli Zaretskii <eliz@gnu.org>
To: Alex Gramiak <agrambot@gmail.com>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [RFC] Using a display_info union instead of a typedef Display_Info
Date: Fri, 12 Apr 2019 20:55:54 +0300 [thread overview]
Message-ID: <83v9zjkt05.fsf@gnu.org> (raw)
In-Reply-To: <87mukvw4la.fsf@gmail.com> (message from Alex Gramiak on Fri, 12 Apr 2019 10:50:09 -0600)
> From: Alex Gramiak <agrambot@gmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Fri, 12 Apr 2019 10:50:09 -0600
>
> The jist of the attached patch is that generalizes x_get_string_resource
> into a terminal hook, and in the process changes several procedures to
> use union display_info instead of the typedef Display_Info, which is
> display system-dependent. One uses DISPLAY_INFO (dpyinfo) to access the
> common structure of the union, and there are macros
> U_DISPLAY_INFO_<suffix> to convert from a specific display_info to the
> union. There is also a procedure gui_frame_display_info, that grabs a
> window system display_info from a frame.
>
> I've also included a new procedure decode_display_info, which takes the
> role of the display system-dependent check_x_display_info. I've left out
> the removal of the check_x_display_info since I'm not sure if this patch
> will be accepted. I've also left out NS support until a later stage.
>
> WDYT?
Looks to me like replacing one set of window-system specific code with
another: still the same #ifdef's and the same window-system specific
code fragments. Maybe I'm missing something, but it doesn't look to
me like a change for the better.
next prev parent reply other threads:[~2019-04-12 17:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 16:50 [RFC] Using a display_info union instead of a typedef Display_Info Alex Gramiak
2019-04-12 17:06 ` Alex Gramiak
2019-04-16 18:54 ` Paul Eggert
2019-04-17 16:55 ` Eli Zaretskii
2019-04-12 17:55 ` Eli Zaretskii [this message]
2019-04-12 18:40 ` Alex Gramiak
2019-04-12 19:23 ` Eli Zaretskii
2019-04-12 19:36 ` Daniel Colascione
2019-04-12 19:44 ` Eli Zaretskii
2019-04-12 19:55 ` Daniel Colascione
2019-04-12 20:12 ` Eli Zaretskii
2019-04-14 1:17 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v9zjkt05.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=agrambot@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.