From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] Renaming non-X x_* identifiers
Date: Tue, 16 Apr 2019 05:29:29 +0300
Message-ID: <83v9zehed2.fsf@gnu.org>
References: <87wokp4okn.fsf@gmail.com> <87ftrcqg5j.fsf@gmail.com>
	<83bm20nm62.fsf@gnu.org> <87d0men4jx.fsf@gmail.com>
	<83o95sisk7.fsf@gnu.org> <87mulcnui4.fsf@gmail.com>
	<83bm1si7lf.fsf@gnu.org> <87ef6ont03.fsf@gmail.com>
	<83a7hci44l.fsf@gnu.org> <87a7hcndtc.fsf@gmail.com>
	<831s2nhza8.fsf@gnu.org> <87d0lpvq6n.fsf_-_@gmail.com>
	<83r2a5keo7.fsf@gnu.org> <87pnppu4ox.fsf@gmail.com>
	<83muktk9xb.fsf@gnu.org> <875zrhtg2i.fsf@gmail.com>
	<83ftqkk7lr.fsf@gnu.org> <877ebwvatg.fsf@gmail.com>
	<83y34cin3g.fsf@gnu.org> <87y34ctrs1.fsf@gmail.com>
	<83h8azianr.fsf@gnu.org> <jwvv9zfgca2.fsf-monnier+emacs@gnu.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="228229"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 16 04:30:16 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hGDrT-000xH4-UR
	for ged-emacs-devel@m.gmane.org; Tue, 16 Apr 2019 04:30:16 +0200
Original-Received: from localhost ([127.0.0.1]:58199 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1hGDrS-0007mU-Rj
	for ged-emacs-devel@m.gmane.org; Mon, 15 Apr 2019 22:30:14 -0400
Original-Received: from eggs.gnu.org ([209.51.188.92]:50360)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1hGDqr-0007kf-JJ
	for emacs-devel@gnu.org; Mon, 15 Apr 2019 22:29:39 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40365)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1hGDqr-0001lH-9D; Mon, 15 Apr 2019 22:29:37 -0400
Original-Received: from [176.228.60.248] (port=3662 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1hGDqp-0003me-SV; Mon, 15 Apr 2019 22:29:37 -0400
In-reply-to: <jwvv9zfgca2.fsf-monnier+emacs@gnu.org> (message from Stefan
	Monnier on Mon, 15 Apr 2019 18:01:52 -0400)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:235502
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/235502>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Mon, 15 Apr 2019 18:01:52 -0400
> 
> BTW, instead of setting those hook function slots to NULL in
> text-terminals and then test for non-NULL-ness before calling them,
> can't we set them to `the_ignore_function`, which we could implement as
> a vararg function which does nothing?

I thought about that, but calling an empty function would add a small
inefficiency, significantly larger than just a test against NULL.
Besides, the non-NULL tests were already all over the place anyway.