From: Eli Zaretskii <eliz@gnu.org>
To: Alex Gramiak <agrambot@gmail.com>
Cc: 35464@debbugs.gnu.org
Subject: bug#35464: [PATCH] Refactor update_window_begin and update_window_end hooks
Date: Sun, 28 Apr 2019 19:45:22 +0300 [thread overview]
Message-ID: <83v9yyt6xp.fsf@gnu.org> (raw)
In-Reply-To: <87k1ffnnn2.fsf@gmail.com> (message from Alex Gramiak on Sat, 27 Apr 2019 15:28:49 -0600)
> From: Alex Gramiak <agrambot@gmail.com>
> Date: Sat, 27 Apr 2019 15:28:49 -0600
>
> 1) Is it okay to not use reset_mouse_highlight in the generic version
> (ns_update_window_end still uses it)? See commit 60ae3d09932f for why
> reset_mouse_highlight was removed in the x/w32 versions.
Don't know, the problem was specific to X. I think we should leave
the code there, the NS port has enough redisplay problems already.
> 2) Should the #if 0 section be removed in w32_update_window_begin?
Yes, I think we can remove that.
> @@ -13145,8 +13069,8 @@ static struct redisplay_interface x_redisplay_interface =
> gui_clear_end_of_line,
> x_scroll_run,
> x_after_update_window_line,
> - x_update_window_begin,
> - x_update_window_end,
> + gui_update_window_begin,
> + gui_update_window_end,
> x_flip_and_flush,
> gui_clear_window_mouse_face,
> gui_get_glyph_overhangs,
This looks like a step in the wrong direction to me: the different
implementations are all almost completely identical, except that w32
has a small quirk there. So I'd say make a single function
window_update_begin, that will be called directly (not via a hook
pointer), and make the w32 part be an optional hook called only if
non-NULL.
Also, please don't add gui_* functions extracted from the *term.c
files in xdisp.c, as that file is already too large. Renaming
existing functions in xdisp.c is OK, as well as adding static utility
functions. But for new gui_* functions that were originally in
xterm.c etc., I'd prefer a new file, let's call it gui_term.c.
Thanks.
next prev parent reply other threads:[~2019-04-28 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 21:28 bug#35464: [PATCH] Refactor update_window_begin and update_window_end hooks Alex Gramiak
2019-04-27 21:40 ` bug#35463: " Alex Gramiak
2019-04-28 16:45 ` Eli Zaretskii [this message]
2019-04-28 18:37 ` bug#35464: " Alex Gramiak
2019-04-28 18:45 ` Eli Zaretskii
2019-05-03 5:10 ` Alex Gramiak
2019-05-04 8:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v9yyt6xp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=35464@debbugs.gnu.org \
--cc=agrambot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.