From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Removing the usage of X structures (or their names) in independent code Date: Mon, 13 May 2019 20:40:42 +0300 Message-ID: <83v9ye9rs5.fsf@gnu.org> References: <875zqkdzfc.fsf@gmail.com> <83d0ksgo1h.fsf@gnu.org> <87woizd263.fsf@gmail.com> <8336lnh7rw.fsf@gnu.org> <87d0kpilww.fsf@gmail.com> <87woiugwjq.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="124204"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Alex Gramiak Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 13 19:50:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQF5z-000WBj-OA for ged-emacs-devel@m.gmane.org; Mon, 13 May 2019 19:50:39 +0200 Original-Received: from localhost ([127.0.0.1]:32772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQF5y-0005NZ-PM for ged-emacs-devel@m.gmane.org; Mon, 13 May 2019 13:50:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQF3X-0004Qz-Mr for emacs-devel@gnu.org; Mon, 13 May 2019 13:48:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hQEwf-0000n4-NT; Mon, 13 May 2019 13:41:01 -0400 Original-Received: from [176.228.60.248] (port=3059 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hQEwd-0005oj-3r; Mon, 13 May 2019 13:40:59 -0400 In-reply-to: <87woiugwjq.fsf@gmail.com> (message from Alex Gramiak on Mon, 13 May 2019 10:15:53 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236470 Archived-At: > From: Alex Gramiak > Cc: emacs-devel@gnu.org > Date: Mon, 13 May 2019 10:15:53 -0600 > > Alex Gramiak writes: > > > I posted a patch series to the scratch/X_Typedefs branch. WDYT? > > > > The first few patches are straightforward, but the XChar2b patch is a > > bit more involved. > > > > Regarding the last patch, I don't like the names Emacs_Pix_Container > > (XImagePtr) and Emacs_Pix_Context (XImagePtr_or_DC), but I'm lost as to > > better names. > > > > AFAIU XImage is a client-side structure holding bitmap/pixmap data[1]. > > My first thought was "Emacs_Pixmap_Container", but that would be easily > > confused for a container for Emacs_Pixmap. At least the abbreviation > > dissociates the two structures a bit. > > > > [1] https://tronche.com/gui/x/xlib/graphics/images.html > > Ping. Any comments? I'd like to merge this branch to master. Sorry, I was busy and haven't yet time to review the patches. Hopefully tomorrow.