From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Building master fails on Windows 10 when testing etc/NEWS file Date: Wed, 18 Sep 2019 21:33:10 +0300 Message-ID: <83v9tptpy1.fsf@gnu.org> References: <1d388216-eed3-ed6f-5710-18d38daefe58@cs.ucla.edu> <1840bbb1-50de-870d-99d9-b4340e3c3b92@cs.ucla.edu> <83a7b1vkob.fsf@gnu.org> <83zhj1txpi.fsf@gnu.org> <83y2yltt5j.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="197031"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rudalics@gmx.at, emacs-devel@gnu.org To: rcopley@gmail.com, lekktu@gmail.com, eggert@cs.ucla.edu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 18 20:35:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAenj-000p3h-1t for ged-emacs-devel@m.gmane.org; Wed, 18 Sep 2019 20:35:39 +0200 Original-Received: from localhost ([::1]:34316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAenh-00073p-Pw for ged-emacs-devel@m.gmane.org; Wed, 18 Sep 2019 14:35:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52325) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAelP-0006F4-8k for emacs-devel@gnu.org; Wed, 18 Sep 2019 14:33:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iAelO-00078v-1h; Wed, 18 Sep 2019 14:33:14 -0400 Original-Received: from [176.228.60.248] (port=3816 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iAelM-0000I1-FC; Wed, 18 Sep 2019 14:33:13 -0400 In-reply-to: <83y2yltt5j.fsf@gnu.org> (message from Eli Zaretskii on Wed, 18 Sep 2019 20:23:52 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240147 Archived-At: > Date: Wed, 18 Sep 2019 20:23:52 +0300 > From: Eli Zaretskii > Cc: lekktu@gmail.com, eggert@cs.ucla.edu, emacs-devel@gnu.org, rudalics@gmx.at > > Then please run Emacs under GDB, put a breakpoint on line 1437 of > lread.c (that's where that message comes from), and when it breaks, > show the C and Lisp backtraces. Don't bother, I found the culprit. It is this fragment from Fload: if (!load_prefer_newer && is_elc) { result = stat (SSDATA (efound), &s1); int err = errno; if (result == 0) { SSET (efound, SBYTES (efound) - 1, 0); result = stat (SSDATA (efound), &s2); err = errno; SSET (efound, SBYTES (efound) - 1, 'c'); if (result != 0) <<<<<<<<<<< found = Fsubstring (found, make_fixnum (0), <<<<<<<<<<< make_fixnum (-1)); <<<<<<<<<<< } The last 3 lines were added as part of the "improved reporting of I/O errors" changeset. What it does is replace the .elc file name with the .el filename if 'stat' fails when called on the .el file. And in installed Emacs we compress *.el files, so they are not there. Paul, why was this snippet added? It makes no sense to me: why should we replace an existing .elc file name with a non-existing .el file name?