From: Eli Zaretskii <eliz@gnu.org>
To: Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: python: Let pdb tracking not kill buffers
Date: Sat, 02 Nov 2019 19:29:09 +0200 [thread overview]
Message-ID: <83v9s2i3ve.fsf@gnu.org> (raw)
In-Reply-To: <6F09449A-0EDF-4D7C-86DC-EE466CE032C8@gmail.com> (message from Andrii Kolomoiets on Sat, 2 Nov 2019 18:37:26 +0200)
> From: Andrii Kolomoiets <andreyk.mad@gmail.com>
> Date: Sat, 2 Nov 2019 18:37:26 +0200
> Cc: emacs-devel@gnu.org
>
> On 1 Nov 2019, at 11:35, Eli Zaretskii <eliz@gnu.org> wrote:
> > Can you please add:
> >
> > . Commit log message formatted according to instructions in
> > CONTRIBUTE
> > . Suitable short entry for NEWS about the new options
>
> Please see attached updated patch.
Thanks.
> Current python-pdbtrack-stacktrace-info-regexp match only lines with real
> filenames, like:
> > /Users/mad/test.py(3)<module>()->None
>
> Pdb command "next" can bring us to upper stack frame, like:
> > <stdin>(1)<module>()->None
OK, but the change in that variable should be called out in the log
entry, so please add that, together with the explanation above. Maybe
also add a comment before the variable to explain what it needs to
match.
> +*** New user option 'python-pdbtrack-kill-buffers'.
> +If nil, buffers opened during pdbtracking session is not killed when
^^
"are", plural.
Thanks.
next prev parent reply other threads:[~2019-11-02 17:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 20:32 python: Let pdb tracking not kill buffers Andrii Kolomoiets
2019-10-05 6:40 ` Eli Zaretskii
2019-10-07 4:33 ` Lawrence Liu
2019-10-07 16:19 ` Eli Zaretskii
2019-10-07 16:26 ` Lawrence Liu
2019-10-07 12:28 ` Andrii Kolomoiets
2019-10-30 19:14 ` Andrii Kolomoiets
2019-11-01 9:35 ` Eli Zaretskii
2019-11-02 16:37 ` Andrii Kolomoiets
2019-11-02 17:29 ` Eli Zaretskii [this message]
2019-11-02 18:51 ` Andrii Kolomoiets
2019-11-07 16:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v9s2i3ve.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andreyk.mad@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.