From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 30373@debbugs.gnu.org, sjindel@google.com
Subject: bug#30373: [PATCH] Implement finalizers for module functions (Bug#30373)
Date: Fri, 03 Jan 2020 20:44:26 +0200 [thread overview]
Message-ID: <83v9psgz1x.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkQKn9W+T5G8-jHSPPY9tudgRzRNS-aKG2C4bCO5e551SQ@mail.gmail.com> (message from Philipp Stephani on Fri, 3 Jan 2020 19:34:51 +0100)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 3 Jan 2020 19:34:51 +0100
> Cc: Philipp Stephani <phst@google.com>
>
> Since there were no objections, I've installed this patch (plus some
> documentation) as commit 48ffef5ef4 into master.
Thanks.
The new test fails for me on MS-Windows:
Test module/function-finalizer backtrace:
signal(ert-test-failed (((should (equal (mod-test-function-finalizer
ert-fail(((should (equal (mod-test-function-finalizer-calls) expecte
(if (unwind-protect (setq value-370 (apply fn-368 args-369)) (setq f
(let (form-description-372) (if (unwind-protect (setq value-370 (app
(let ((value-370 'ert-form-evaluation-aborted-371)) (let (form-descr
(let* ((fn-368 #'equal) (args-369 (condition-case err (let ((signal-
(let* ((previous-calls (mod-test-function-finalizer-calls)) (expecte
(closure (t) nil (mod-test-make-function-with-finalizer) (let* ((pre
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name module/function-finalizer :documentat
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
ert-run-tests-batch((not (tag :unstable)))
ert-run-tests-batch-and-exit((not (tag :unstable)))
eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
command-line-1((#("-L" 0 2 (charset cp862)) #(";." 0 2 (charset cp86
command-line()
normal-top-level()
Test module/function-finalizer condition:
(ert-test-failed
((should
(equal
(mod-test-function-finalizer-calls)
expected-calls))
:form
(equal
(0 0)
(1 0))
:value nil :explanation
(list-elt 0
(different-atoms
(0 "#x0" "?
next prev parent reply other threads:[~2020-01-03 18:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 21:17 bug#30373: Support finalizers for functions created in dynamic modules Samir Jindel
2019-12-23 20:41 ` Philipp Stephani
2019-12-26 0:04 ` bug#30373: [PATCH] Implement finalizers for module functions (Bug#30373) Philipp Stephani
2020-01-03 18:34 ` Philipp Stephani
2020-01-03 18:44 ` Eli Zaretskii [this message]
2020-01-03 18:53 ` Pip Cet
2020-01-03 20:13 ` Eli Zaretskii
2020-01-03 20:49 ` Pip Cet
2020-01-04 19:56 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v9psgz1x.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30373@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
--cc=sjindel@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.