From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails Date: Fri, 07 Feb 2020 16:00:52 +0200 Message-ID: <83v9oiebu3.fsf@gnu.org> References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> <834kw2g1ur.fsf@gnu.org> <38ea415e-9993-806c-3006-85e6e435fbd5@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="14177"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 07 15:02:28 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j04DE-0003Wq-7v for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Feb 2020 15:02:28 +0100 Original-Received: from localhost ([::1]:57048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j04DD-0002tD-6B for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Feb 2020 09:02:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44962) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j04Cp-0002iJ-Hg for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 09:02:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j04Co-0000ML-76 for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 09:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43049) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j04Co-0000MB-2C for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 09:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j04Co-0004NI-0E for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 09:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Feb 2020 14:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39380 X-GNU-PR-Package: emacs Original-Received: via spool by 39380-submit@debbugs.gnu.org id=B39380.158108411216797 (code B ref 39380); Fri, 07 Feb 2020 14:02:01 +0000 Original-Received: (at 39380) by debbugs.gnu.org; 7 Feb 2020 14:01:52 +0000 Original-Received: from localhost ([127.0.0.1]:49022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j04Cd-0004Mq-Qz for submit@debbugs.gnu.org; Fri, 07 Feb 2020 09:01:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j04Cc-0004Mb-IX for 39380@debbugs.gnu.org; Fri, 07 Feb 2020 09:01:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j04CV-0008NA-Ea; Fri, 07 Feb 2020 09:01:45 -0500 Original-Received: from [176.228.60.248] (port=3018 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j04CS-0003Db-0x; Fri, 07 Feb 2020 09:01:42 -0500 In-reply-to: <38ea415e-9993-806c-3006-85e6e435fbd5@yandex.ru> (message from Dmitry Gutov on Fri, 7 Feb 2020 14:03:21 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175748 Archived-At: > Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de > From: Dmitry Gutov > Date: Fri, 7 Feb 2020 14:03:21 +0300 > > On 07.02.2020 12:53, Eli Zaretskii wrote: > > I'll have to ask you to walk me through the change and explain how it > > solves the original issue. > > There are two changes: > > 1. Having the returned file names relative to the working dir instead of > the repository root. For that, we change 'hg status' to 'hg status re:'. Why do we want the file names to be relative? If default-directory of the buffer is set correctly, that shouldn't be necessary, and if the file names are absolute, then the default-directory doesn't even matter much. > 2. Only including the files inside the working dir in the output. That > happens by adding '-I .' to the arguments. Otherwise, Mercurial adds, in > the presented scenario, an entry like '../sub2/x', which is extraneous. This change should be in NEWS, IMO. > > the Mercurial documentation I've read seems > > to contradict what you are doing (e.g., it says "re:" should be > > immediately followed by a regexp). > > You can search the manual for "hg status re:". Which only finds a single example, where this notation is not explained at all (and which I already saw). > I agree it's a bit unclear (it also mentions "hg help patterns" for some > reason), but here's an SO answer that got me this far: > https://stackoverflow.com/a/46743585/615245 Isn't it disturbing that we are using a feature that doesn't seem to be documented? But to get to the issue at hand: you are saying that "C-x v d" in a subdirectory of the root of a Mercurial repository became broken in Emacs 25.1? Also, is DIR guaranteed to be the directory where FILES live?