From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#6695: bug#8439: [PATCH] ffap.el -- detect paths with spaces (v4) Date: Sat, 15 Aug 2020 12:07:52 +0300 Message-ID: <83v9hkjmzb.fsf@gnu.org> References: <87pqoyaxu0.fsf@blue.sea.net> <87zk3i7tbu.fsf@picasso.cante.net> <20121020075601.GD29154@picasso.cante.net> <20121020084551.GE29154@picasso.cante.net> <87mucmn2gs.fsf@gnus.org> <87tux574te.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25165"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 8439@debbugs.gnu.org, 6695@debbugs.gnu.org, jari.aalto@cante.net To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 15 11:09:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6sBZ-0006Lh-SV for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 11:09:09 +0200 Original-Received: from localhost ([::1]:60560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6sBY-0006E7-DA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Aug 2020 05:09:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k6sBS-0006Du-Ad for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 05:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42717) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k6sBS-0007ZA-0d for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 05:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k6sBR-0000W2-S2 for bug-gnu-emacs@gnu.org; Sat, 15 Aug 2020 05:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Aug 2020 09:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6695-submit@debbugs.gnu.org id=B6695.15974824881916 (code B ref 6695); Sat, 15 Aug 2020 09:09:01 +0000 Original-Received: (at 6695) by debbugs.gnu.org; 15 Aug 2020 09:08:08 +0000 Original-Received: from localhost ([127.0.0.1]:54261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6sAZ-0000Uo-Tm for submit@debbugs.gnu.org; Sat, 15 Aug 2020 05:08:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6sAW-0000UF-DB; Sat, 15 Aug 2020 05:08:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47159) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k6sAQ-0007VW-IC; Sat, 15 Aug 2020 05:07:58 -0400 Original-Received: from [176.228.60.248] (port=4282 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k6sAP-00082S-Vx; Sat, 15 Aug 2020 05:07:58 -0400 In-Reply-To: <87tux574te.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 14 Aug 2020 15:08:45 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185204 Archived-At: > From: Lars Ingebrigtsen > Cc: 8439@debbugs.gnu.org, 6695@debbugs.gnu.org, Eli Zaretskii > Date: Fri, 14 Aug 2020 15:08:45 +0200 > > I've respun the patch so that it now applies to Emacs 28, and the test > cases seem to kinda work? Thanks. > The c: isn't included, but is that to be expected? Is it? I thought the intent was to include the full file name, which means the drive letter should be included. Otherwise the file will not be found. > So what do people think? Good or bad? Does this work in any way > sensibly for people? Since the heuristic only covers some use cases, I think we should have it off by default, and we should document its potential pitfalls in the doc string. With those qualifications, I'm okay with adding this optional feature.