From: Eli Zaretskii <eliz@gnu.org>
To: Andrea Corallo <akrl@sdf.org>
Cc: davide.restivo@yahoo.it, 45934@debbugs.gnu.org
Subject: bug#45934: native-comp - Dylib ID of ELN files not optimal
Date: Fri, 29 Jan 2021 09:09:29 +0200 [thread overview]
Message-ID: <83v9bgxlqu.fsf@gnu.org> (raw)
In-Reply-To: <xjfo8h8vi2z.fsf@sdf.org> (bug-gnu-emacs@gnu.org)
> Date: Thu, 28 Jan 2021 21:59:16 +0000
> Cc: 45934@debbugs.gnu.org
> From: akrl--- via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> +/* On MacOS set a unique dylib ID (Bug#45934). */
> +#if defined (LIBGCCJIT_HAVE_gcc_jit_context_add_driver_option) \
> + && defined (DARWIN_OS)
> + gcc_jit_context_add_driver_option (
> + comp.ctxt,
> + SSDATA (concat2 (build_string ("-install_name "),
> + Ffile_name_nondirectory (filename))));
> +#endif
A minor nit unrelated to the issue at hand: if you take care to
mention the bug number in the commit log message, there's no need to
do that in the comments.
In general, I don't think it's a good idea to have our sources full of
references to bug reports; if the comment by itself doesn't explain
the underlying issue, it is better to enhance the comment to be
self-contained. IMO, a reference to a bug in the comments is only
justified when the issue is so complicated to explain that having such
an explanation in comments is impractical.
TIA
next prev parent reply other threads:[~2021-01-29 7:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <EDAEF3DD-6B4E-4ED9-A7B8-8FB4F236DF42.ref@yahoo.it>
2021-01-17 10:13 ` bug#45934: native-comp - Dylib ID of ELN files not optimal davide.restivo--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-17 12:36 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-17 16:48 ` davide.restivo--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-17 20:06 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-23 16:13 ` davide.restivo--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-24 19:37 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-28 21:59 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-29 7:09 ` Eli Zaretskii [this message]
2021-01-29 8:52 ` akrl--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-01-30 8:18 ` davide.restivo--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-02-11 16:00 ` xgutter--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-30 12:32 ` Lars Ingebrigtsen
2021-08-02 14:19 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-04 6:55 ` Lars Ingebrigtsen
2021-08-04 18:11 ` Alan Third
2021-08-05 10:54 ` Lars Ingebrigtsen
2021-08-05 19:00 ` Alan Third
2021-08-06 10:49 ` Lars Ingebrigtsen
2021-08-06 16:37 ` Alan Third
2021-08-07 9:52 ` Lars Ingebrigtsen
2021-08-07 9:57 ` Lars Ingebrigtsen
2021-08-07 10:25 ` Lars Ingebrigtsen
2021-08-07 13:11 ` Alan Third
2021-08-09 12:20 ` Lars Ingebrigtsen
2021-08-22 17:18 ` Davide Restivo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-22 19:40 ` Davide Restivo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-22 21:18 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v9bgxlqu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=45934@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=davide.restivo@yahoo.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.