* Re: master a283996: Add command for customizing current newsticker feed @ 2021-02-23 17:35 Eli Zaretskii 2021-02-23 18:38 ` Ulf Jasper 0 siblings, 1 reply; 4+ messages in thread From: Eli Zaretskii @ 2021-02-23 17:35 UTC (permalink / raw) To: Ulf Jasper; +Cc: emacs-devel The new code installed by this change triggers a warning: In newsticker-customize-feed: net/newst-backend.el:656:46: Warning: reference to free variable `feed-name' And this code looks strange to me: +(defun newsticker-customize-feed (feed-name) + "Open customization buffer for `newsticker-url-list' and jump to FEED-NAME." + (interactive + (list (completing-read "Name of feed or group to edit: " + (append (mapcar #'car newsticker-url-list) + nil t feed-name)))) Look at the arguments of 'append': what is that supposed to do? And how can the 'interactive' form reference the argument list that it's supposed to generate? What am I missing? Thanks. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master a283996: Add command for customizing current newsticker feed 2021-02-23 17:35 master a283996: Add command for customizing current newsticker feed Eli Zaretskii @ 2021-02-23 18:38 ` Ulf Jasper 0 siblings, 0 replies; 4+ messages in thread From: Ulf Jasper @ 2021-02-23 18:38 UTC (permalink / raw) To: Eli Zaretskii; +Cc: emacs-devel Am 23.02.2021 um 19:35 (+0200) schrieb Eli Zaretskii: > And how can the 'interactive' form reference the argument list that > it's supposed to generate? What am I missing? Thanks for pointing out. This is fixed now. ulf ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20210223164040.7990.38864@vcs0.savannah.gnu.org>]
[parent not found: <20210223164041.9DA5D20536@vcs0.savannah.gnu.org>]
* Re: master a283996: Add command for customizing current newsticker feed [not found] ` <20210223164041.9DA5D20536@vcs0.savannah.gnu.org> @ 2021-02-23 17:05 ` Basil L. Contovounesios 2021-02-23 18:38 ` Ulf Jasper 0 siblings, 1 reply; 4+ messages in thread From: Basil L. Contovounesios @ 2021-02-23 17:05 UTC (permalink / raw) To: Ulf Jasper; +Cc: emacs-devel ulf.jasper@web.de (Ulf Jasper) writes: > branch: master > commit a283996fc728e249816d3bd43a6da1f3c0eab837 > Author: Ulf Jasper <ulf.jasper@web.de> > Commit: Ulf Jasper <ulf.jasper@web.de> > > Add command for customizing current newsticker feed [...] > +(defun newsticker-customize-feed (feed-name) > + "Open customization buffer for `newsticker-url-list' and jump to FEED-NAME." > + (interactive > + (list (completing-read "Name of feed or group to edit: " > + (append (mapcar #'car newsticker-url-list) FWIW, completing-read also accepts alists with string/symbol keys directly. > + nil t feed-name)))) This call to (append (..) nil t feed-name) will signal an error. > + (customize-variable 'newsticker-url-list) > + (delete-other-windows) Doesn't this interfere with the user's display-buffer-alist customisations? customize-variable uses pop-to-buffer, so in theory no further window adjustment should be necessary. > + (when (re-search-forward (concat "Label: " feed-name) nil t) Should this be 'search-forward' instead? Thanks, -- Basil ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: master a283996: Add command for customizing current newsticker feed 2021-02-23 17:05 ` Basil L. Contovounesios @ 2021-02-23 18:38 ` Ulf Jasper 0 siblings, 0 replies; 4+ messages in thread From: Ulf Jasper @ 2021-02-23 18:38 UTC (permalink / raw) To: Basil L. Contovounesios; +Cc: emacs-devel Am 23.02.2021 um 17:05 (+0000) schrieb Basil L. Contovounesios: > This call to (append (..) nil t feed-name) will signal an error. This is fixed now. >> + (customize-variable 'newsticker-url-list) >> + (delete-other-windows) > > Doesn't this interfere with the user's display-buffer-alist > customisations? customize-variable uses pop-to-buffer, so in > theory no further window adjustment should be necessary. Removed call to 'delete-other-windows'. >> + (when (re-search-forward (concat "Label: " feed-name) nil t) > > Should this be 'search-forward' instead? Changed. Thanks! ulf ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-23 18:38 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-02-23 17:35 master a283996: Add command for customizing current newsticker feed Eli Zaretskii 2021-02-23 18:38 ` Ulf Jasper [not found] <20210223164040.7990.38864@vcs0.savannah.gnu.org> [not found] ` <20210223164041.9DA5D20536@vcs0.savannah.gnu.org> 2021-02-23 17:05 ` Basil L. Contovounesios 2021-02-23 18:38 ` Ulf Jasper
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.