From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master a283996: Add command for customizing current newsticker
 feed
Date: Tue, 23 Feb 2021 19:35:58 +0200
Message-ID: <83v9aiu1oh.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="8924"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Ulf Jasper <ulf.jasper@web.de>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 23 18:38:05 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lEbdL-0002Bw-A2
	for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Feb 2021 18:38:03 +0100
Original-Received: from localhost ([::1]:57258 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lEbdK-0002Rk-Cd
	for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Feb 2021 12:38:02 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53902)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lEbbS-0001ZV-Ij
 for emacs-devel@gnu.org; Tue, 23 Feb 2021 12:36:06 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48626)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lEbbS-0002gF-BI; Tue, 23 Feb 2021 12:36:06 -0500
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2188
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lEbbR-0006yb-NZ; Tue, 23 Feb 2021 12:36:06 -0500
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:265542
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/265542>

The new code installed by this change triggers a warning:

  In newsticker-customize-feed:
  net/newst-backend.el:656:46: Warning: reference to free variable `feed-name'

And this code looks strange to me:

  +(defun newsticker-customize-feed (feed-name)
  +  "Open customization buffer for `newsticker-url-list' and jump to FEED-NAME."
  +  (interactive
  +   (list (completing-read "Name of feed or group to edit: "
  +                          (append (mapcar #'car newsticker-url-list)
  +                                  nil t feed-name))))

Look at the arguments of 'append': what is that supposed to do?

And how can the 'interactive' form reference the argument list that
it's supposed to generate?  What am I missing?

Thanks.