From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Ugly regexps
Date: Wed, 03 Mar 2021 18:30:30 +0200 [thread overview]
Message-ID: <83v9a8jj2x.fsf@gnu.org> (raw)
In-Reply-To: <jwv8s74jlav.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Wed, 03 Mar 2021 10:46:20 -0500)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Wed, 03 Mar 2021 10:46:20 -0500
>
> >> (string-match (ere "\\(def(macro|un|subst) .{1,}"))
> >>
> >> instead of
> >>
> >> (string-match "(def\\(macro\\|un\\|subst\\) .\\{1,\\}")
> >
> > Why not use 'rx' in those cases?
>
> Not sure what you mean by "those cases". I'm thinking this `ere` would
> be useful for the cases where the author finds `rx` unpalatable for
> some reason.
Why would someone find rx unpalatable?
> > IMO it makes the regexp even more easy to write and read.
>
> I believe this depends on taste and circumstances. Experience shows
> that while some packages use `rx` extensively, most ELisp code doesn't.
If this is about personal preferences and tastes, then I think having
3 different flavors of regexps in our sources due to personal
preferences is not necessarily a good idea. We have coding
conventions for a reason.
next prev parent reply other threads:[~2021-03-03 16:30 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 0:32 Ugly regexps Stefan Monnier
2021-03-03 1:32 ` Stefan Kangas
2021-03-03 2:08 ` Stefan Kangas
2021-03-03 6:19 ` Eli Zaretskii
2021-03-03 20:46 ` Alan Mackenzie
2021-03-04 18:35 ` Stefan Kangas
2021-03-03 6:00 ` Eli Zaretskii
2021-03-03 15:46 ` Stefan Monnier
2021-03-03 16:30 ` Eli Zaretskii [this message]
2021-03-03 17:44 ` Stefan Monnier
2021-03-03 18:46 ` Stefan Kangas
2021-03-03 19:21 ` Eli Zaretskii
2021-03-03 19:50 ` Stefan Kangas
2021-03-03 20:16 ` Stefan Kangas
2021-03-03 19:50 ` Stefan Kangas
2021-03-03 19:58 ` Dmitry Gutov
2021-03-03 20:07 ` [External] : " Drew Adams
2021-03-03 20:31 ` Stefan Kangas
2021-03-03 22:17 ` Drew Adams
2021-03-03 22:32 ` Stefan Monnier
2021-03-03 20:32 ` Stefan Monnier
2021-03-04 5:47 ` Eli Zaretskii
2021-03-04 10:49 ` Lars Ingebrigtsen
2021-03-04 11:25 ` Mattias Engdegård
2021-03-04 11:28 ` Alan Mackenzie
2021-03-04 14:11 ` Eli Zaretskii
2021-03-04 14:25 ` Dmitry Gutov
2021-03-04 14:50 ` tomas
2021-03-04 15:04 ` Dmitry Gutov
2021-03-05 5:45 ` Richard Stallman
2021-03-05 11:47 ` Dmitry Gutov
2021-03-06 5:11 ` Richard Stallman
2021-03-04 15:05 ` Dmitry Gutov
2021-03-04 15:11 ` Eli Zaretskii
2021-03-03 19:32 ` [External] : " Drew Adams
2021-03-03 7:09 ` Helmut Eller
2021-03-03 14:11 ` Stefan Kangas
2021-03-03 16:40 ` Stefan Monnier
2021-03-03 15:49 ` Stefan Monnier
2021-03-03 12:17 ` Dmitry Gutov
2021-03-03 15:48 ` Stefan Monnier
2021-03-03 13:57 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v9a8jj2x.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.