From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 050b830 3/3: Do interactive mode tagging for finder.el Date: Fri, 19 Mar 2021 10:37:09 +0200 Message-ID: <83v99nedze.fsf@gnu.org> References: <83zgyzeezu.fsf@gnu.org> <87eegbo8db.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11423"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 19 09:38:45 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNAeb-0002so-0J for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Mar 2021 09:38:45 +0100 Original-Received: from localhost ([::1]:45208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNAea-00032Q-0P for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Mar 2021 04:38:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNAd3-0002aS-Do for emacs-devel@gnu.org; Fri, 19 Mar 2021 04:37:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46404) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNAd2-0001BQ-BF; Fri, 19 Mar 2021 04:37:08 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2471 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lNAd0-0000s0-JX; Fri, 19 Mar 2021 04:37:07 -0400 In-Reply-To: <87eegbo8db.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 19 Mar 2021 09:28:16 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266592 Archived-At: > From: Lars Ingebrigtsen > Cc: Stefan Kangas , emacs-devel@gnu.org > Date: Fri, 19 Mar 2021 09:28:16 +0100 > > Eli Zaretskii writes: > > > I think this part is dangerous: mouse commands are not necessarily > > issued with the buffer on which they operate being current, so > > conditioning such commands on the mode of the current buffer is > > ill-advised. > > It's a command that is applicable only to finder-mode buffers, so I > think the tagging is correct? It depends on what we do with the tag. "Applicable only to finder-mode buffers" doesn't tell how we use this information. We use it to filter out commands as irrelevant in certain contexts. But this command _is_ relevant even when the major mode of the current buffer is something other than finder-mode, because the user can click on text in a non-selected window.