From: Eli Zaretskii <eliz@gnu.org>
To: dick.r.chiang@gmail.com
Cc: 52378-done@debbugs.gnu.org
Subject: bug#52378: 28.0.50; [PATCH] Reinstate a guard on compute_window_start()
Date: Thu, 09 Dec 2021 09:22:33 +0200 [thread overview]
Message-ID: <83v8zyuts6.fsf@gnu.org> (raw)
In-Reply-To: <87tufibxzg.fsf@dick> (dick.r.chiang@gmail.com)
> From: dick.r.chiang@gmail.com
> Date: Wed, 08 Dec 2021 16:14:27 -0500
>
> >From c0d3b2f75cd1ef0d4b45442ab073d8cd0a448a08 Mon Sep 17 00:00:00 2001
> From: dickmao <dick.r.chiang@gmail.com>
> Date: Wed, 8 Dec 2021 16:11:34 -0500
> Subject: [PATCH] A common error
>
> * src/xdisp.c (compute_window_start_on_continuation_line):
> Align code with comment.
The current code is correct. It's the comment that might confuse: it
describes the conditions under which we do NOT want to execute the
code in the following block (that's what "give up" means in this
case). So "||" is correct, and you need to reverse the conditions to
understand what the comment says. For example, it says "too far", but
the condition says "less than", not "greater than".
I tried to clarify the comment on the release branch.
next prev parent reply other threads:[~2021-12-09 7:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 21:14 bug#52378: 28.0.50; [PATCH] Reinstate a guard on compute_window_start() dick.r.chiang
2021-12-09 7:22 ` Eli Zaretskii [this message]
2021-12-09 9:49 ` dick
2021-12-09 19:31 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8zyuts6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=52378-done@debbugs.gnu.org \
--cc=dick.r.chiang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.