From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53598: 28.0.91; occur-after-change function errors with args-out-of-range in occur-edit-mode Date: Sat, 29 Jan 2022 09:57:10 +0200 Message-ID: <83v8y3asa1.fsf@gnu.org> References: <83ilu4c4uq.fsf@gnu.org> <0NPcz-lChmODiW2pVH7owoZ-WjNR6NZOTXu-MTBKffpWKXgls36rAs9M0AT8Y81PGeNqZaCsFteFxnUDa4v-HaCFSBZfHcFfLjVkh-mKZqg=@proofte.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35019"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattiase@acm.org, 53598@debbugs.gnu.org To: Jack Henahan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 29 08:59:02 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDidS-0008yG-Ih for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Jan 2022 08:59:02 +0100 Original-Received: from localhost ([::1]:59248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDidQ-00052h-Um for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Jan 2022 02:59:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDicU-00051f-5s for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2022 02:58:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39813) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDicT-00038r-RA for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2022 02:58:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nDicT-0007lG-Ls for bug-gnu-emacs@gnu.org; Sat, 29 Jan 2022 02:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jan 2022 07:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53598 X-GNU-PR-Package: emacs Original-Received: via spool by 53598-submit@debbugs.gnu.org id=B53598.164344305129793 (code B ref 53598); Sat, 29 Jan 2022 07:58:01 +0000 Original-Received: (at 53598) by debbugs.gnu.org; 29 Jan 2022 07:57:31 +0000 Original-Received: from localhost ([127.0.0.1]:60949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDibz-0007kT-FD for submit@debbugs.gnu.org; Sat, 29 Jan 2022 02:57:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDibx-0007kF-3N for 53598@debbugs.gnu.org; Sat, 29 Jan 2022 02:57:29 -0500 Original-Received: from [2001:470:142:3::e] (port=41690 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDibq-000379-Vf; Sat, 29 Jan 2022 02:57:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=427KIo2ACLJdWFE+3t3hZw47vvAC081UF9fLpHbBxXI=; b=NGnRRLvZ/CR327LvFaxu Y9W2ryYCEWQaxpxI1mnCB7VLRfXI8eK8FADtZ6cmwaV+l4X7Gfu3zCLYJV0g4eORNCJLbLZEFjbZL o3dDn1KZsHtbqmj/1ZZqYoisS1rzYvSr0WIoD+EUOhpDAas5GB9li1dYFrYjT0G6VdsFmcGF/besd UPioVyNryoRNW/w5qMbn9qeqwHSGSrt55C3HD1KS8K/Qs99TtJ/03jN/5Kdba9DD37KVlOrTWZetK FcCbTxpGqqz6YtYgLgI61WRc1EWXlRnNRaRfHv1Dg652Xf0TGXnprqYDTWEUe51sn7oMFUl42yDoe xtjjAJnt2VeMRA==; Original-Received: from [87.69.77.57] (port=3097 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDibo-0001S8-WE; Sat, 29 Jan 2022 02:57:22 -0500 In-Reply-To: (message from Jack Henahan on Fri, 28 Jan 2022 23:38:49 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225511 Archived-At: > Date: Fri, 28 Jan 2022 23:38:49 +0000 > From: Jack Henahan > Cc: Mattias Engdegård , 53598@debbugs.gnu.org > > I may have spoken too soon. It looks like there's an edge case on either end of an occurrence line. With the attached reproducer file in `emacs -Q': > > M-s o buffer RET > C-x o > n > C-e > e > DEL > > Debugger entered--Lisp error: (args-out-of-range "(setq minibuffer-prompt-pe" 26 0) > occur-after-change-function(77 77 1) > delete-backward-char(1 nil) > funcall-interactively(delete-backward-char 1 nil) > command-execute(delete-backward-char) Thanks, this is a separate problem. The following patch should solve that one as well: diff --git a/lisp/replace.el b/lisp/replace.el index 45bd05d..b1cfd7e 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -1413,10 +1413,15 @@ occur-after-change-function (length s1))))) (prefix-len (funcall common-prefix buf-str text)) (suffix-len (funcall common-prefix - (reverse buf-str) (reverse text)))) + (reverse (substring + buf-str prefix-len)) + (reverse (substring + text prefix-len))))) (setq beg-pos (+ beg-pos prefix-len)) (setq end-pos (- end-pos suffix-len)) - (setq text (substring text prefix-len (- suffix-len))) + (setq text (substring text prefix-len + (and (not (zerop suffix-len)) + (- suffix-len)))) (delete-region beg-pos end-pos) (goto-char beg-pos) (insert text)))