From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: etags name collision. Date: Tue, 12 Apr 2022 15:15:24 +0300 Message-ID: <83v8ve4hwj.fsf@gnu.org> References: <20220411124736.3qijvtearh6wlen7.ref@Ergus> <20220411124736.3qijvtearh6wlen7@Ergus> <83pmln69n0.fsf@gnu.org> <20220411134749.ps6g5ulpbamzm6ot@Ergus> <83k0bv679q.fsf@gnu.org> <20220411154635.qfw2ijpdahiv5ctl@Ergus> <83fsmj62jl.fsf@gnu.org> <20220411161942.xsqr3ekorpm6jf6y@Ergus> <83ee2360aq.fsf@gnu.org> <20220411191933.wyxvmgpyd4hnpfc2@Ergus> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20292"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 12 14:17:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neFSe-00056p-JA for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 14:17:32 +0200 Original-Received: from localhost ([::1]:50230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1neFSd-00015g-7e for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 08:17:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neFQZ-0006XT-FH for emacs-devel@gnu.org; Tue, 12 Apr 2022 08:15:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neFQY-0001pQ-S7; Tue, 12 Apr 2022 08:15:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4O9ymfVLFjI0dnirPiJ5gXH1fqHhKLhwJYKxyWxhGcs=; b=cY8G+rUTUeDQ wmlpKqj+Tzo6HsoP8T04Woh80+5nT4YZp4H/FxXgD8voxs4NqYz8TPUcbUQmumc6GpwgxLBcqwDOV zW3l56XNlNMQpJeulLpAWiYeA8BBo/9jJujKhm2MYuLqbFzKqapjQJQHwFhrjyD1U1Qwk6fs/Fhjm ArzmCOIdFc7QJ09QXI4Dtm6i+aQD0mTGU+px3SJws9J3apbYwGL9ZWg6wfHz2Rs2m08aRJXCnJXfW mxzL9K4o63dlb6UHS446Gz0ex8kFitXIhbcoatuN/Y4lM7feuN3wCtaRjk8mD2WIqpcgjQvLAweUB 3IMj/IoShb2xFoMqs3177Q==; Original-Received: from [87.69.77.57] (port=2912 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neFQW-0002Pm-M5; Tue, 12 Apr 2022 08:15:22 -0400 In-Reply-To: <20220411191933.wyxvmgpyd4hnpfc2@Ergus> (message from Ergus on Mon, 11 Apr 2022 21:19:33 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288297 Archived-At: > Date: Mon, 11 Apr 2022 21:19:33 +0200 > From: Ergus > Cc: emacs-devel@gnu.org > > >> (ctags --version) >/dev/null 2>&1 || with_ctags=no > >> > >> Isn't this enough? > > > >No, because AFAIU this test will succeed also if the installed ctags > >is (an older version) of the program that came with (an older version) > >of Emacs. You need to make sure the text emitted by --version does > >NOT include "GNU Emacs". > > > Now? Seems like this idea makes some people unhappy, but anyway: > + (ctags --version | grep "GNU Emacs") 2>/dev/null || with_ctags=no I think you want (ctags --version | grep "GNU Emacs") >/dev/null 2>&1 || with_ctags=no here. > -INSTALLABLES = etags${EXEEXT} ctags${EXEEXT} emacsclient${EXEEXT} $(CLIENTW) \ > - ebrowse${EXEEXT} > +INSTALLABLES = etags${EXEEXT} emacsclient${EXEEXT} $(CLIENTW) ebrowse${EXEEXT} \ > + $(if $(with_ctags), , ctags${EXEEXT}) Isn't it easier to replace the literal "ctags" with a value computed by the configure script, than have configure compute a flag variable, and then use $(if ...) in the Makefile?