From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45333: complex command history should not save optional nil parameters Date: Thu, 09 Jun 2022 13:33:14 +0300 Message-ID: <83v8ta2kk5.fsf@gnu.org> References: <0DJzRuBn1S9jW_MoJt5HXcLQWrzb7Vjkfmlwa9zPvgLIFeEfdPLoiguSztbL4TnuHyxd59Z7BpS9qJo5BinMO3n1mDlWjcytLjq9HmoGIl0=@protonmail.com> <8735ggk7nz.fsf@gnus.org> <83ee007gxo.fsf@gnu.org> <87o7z3bcsp.fsf@gnus.org> <83czfj5kco.fsf@gnu.org> <87tu8u87b7.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31872"; mail-complaints-to="usenet@ciao.gmane.io" Cc: laszlomail@protonmail.com, 45333@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 09 14:52:50 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzHeb-00085X-Ca for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 14:52:49 +0200 Original-Received: from localhost ([::1]:37298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzHea-0004hj-1t for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jun 2022 08:52:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzFUJ-00032e-Ji for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 06:34:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51198) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzFUI-00031h-Bl for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 06:34:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzFUI-0001zT-99 for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2022 06:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jun 2022 10:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45333-submit@debbugs.gnu.org id=B45333.16547708097577 (code B ref 45333); Thu, 09 Jun 2022 10:34:02 +0000 Original-Received: (at 45333) by debbugs.gnu.org; 9 Jun 2022 10:33:29 +0000 Original-Received: from localhost ([127.0.0.1]:45090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzFTl-0001y8-Gm for submit@debbugs.gnu.org; Thu, 09 Jun 2022 06:33:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzFTj-0001xu-JK for 45333@debbugs.gnu.org; Thu, 09 Jun 2022 06:33:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzFTe-0002nc-BS; Thu, 09 Jun 2022 06:33:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cv16PhvPMNnWSsF2A3UkzNBf8YbMOtSAT0cOUEeFB7k=; b=CEs0sM75eZhV NcqlBzKuxhEeF7YvcBbXrUJBIR4THngLEat4E88cqRbWjnCSmPU6ErV3mEZKOVFQUccpCxXRzpCCp 79nUrRPy9U47Yj5Tf7OTSaVhRpsnJRZ9wpAbQiErU6curTdPCNntvv74ZKipAoGUmKF88YLOdA4pD ttYyDmh20QCoMV7QwhkAfmuUdp7AclYaMFMdMYYy1iZjXKyRW1fUgLFeVO3/HkXzEZ47O83LMDeAu T79xlTbhnjXbzsAUmBwRSR+5CRc45Op0OHZPidKqsmdXmLHD7+3vz4hB8qC1sCI5NXDsui01SJKeD SnaQJBUEkTnG2dEAbCOs1Q==; Original-Received: from [87.69.77.57] (port=4478 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzFTZ-0006Ol-LR; Thu, 09 Jun 2022 06:33:20 -0400 In-Reply-To: <87tu8u87b7.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 09 Jun 2022 12:22:52 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234040 Archived-At: > From: Lars Ingebrigtsen > Cc: laszlomail@protonmail.com, 45333@debbugs.gnu.org > Date: Thu, 09 Jun 2022 12:22:52 +0200 > > Eli Zaretskii writes: > > >> (replace-string "foo" "bar" nil nil nil nil nil) > >> > >> in `command-history' -- where all those nils are optional. We could > >> pretty easily filter those out by looking at the signature of the > >> function and peeling off trailing nils, I think? Would there be any > >> disadvantages to doing so? > > > > I don't see any advantages, FWIW. > > The advantage would be that the history is easier to navigate, because > you don't have to stare at all those nils when going through the list > looking for the command to execute. OTOH, you get to see all the optional arguments, which is also useful. It's a minor issue, to be sure.