From: Eli Zaretskii <eliz@gnu.org>
To: Duncan Findlay <duncf@google.com>
Cc: 55883@debbugs.gnu.org
Subject: bug#55883: [PATCH] Update X Primary Selection with active regions
Date: Wed, 15 Jun 2022 19:51:10 +0300 [thread overview]
Message-ID: <83v8t1rhtt.fsf@gnu.org> (raw)
In-Reply-To: <CAPANw+PyG2OD_Vw0dLO3T7qX1T3EEN8-B2cTSEguo9e_Z880=w@mail.gmail.com> (message from Duncan Findlay on Tue, 14 Jun 2022 19:01:58 -0700)
> From: Duncan Findlay <duncf@google.com>
> Date: Tue, 14 Jun 2022 19:01:58 -0700
> Cc: 55883@debbugs.gnu.org
>
> > > !NILP (SYMBOL_VAL (XSYMBOL (Qxterm_select_active_regions)))
> >
> > This is not safe, IMO. I think this is better:
> >
> > if ((!NILP (Fwindow_system (Qnil))
> > || ((symval = find_symbol_value (Qxterm_select_active_regions),
> > (!EQ (symval, Qunbound) && !NILP (symval)))
> > && !NILP (Fterminal_parameter (Qnil, Qxterm__set_selection))))
>
> Thanks, I would never have figured that out myself.
That's what we are here for (one reason, at least).
> > > I've also addressed Po's comments about long conditionals.
> >
> > Thanks, the patch LGTM, modulo the above 2 minor nits.
This version LGTM, I will install soon, unless someone comes up with
more comments.
next prev parent reply other threads:[~2022-06-15 16:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 6:18 bug#55883: [PATCH] Update X Primary Selection with active regions Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-10 6:52 ` Eli Zaretskii
2022-06-11 1:59 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-11 7:53 ` Eli Zaretskii
2022-06-14 5:57 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-14 6:36 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-14 12:15 ` Eli Zaretskii
2022-06-15 2:01 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-15 16:51 ` Eli Zaretskii [this message]
2022-06-18 11:13 ` Eli Zaretskii
2022-06-18 15:15 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-18 16:09 ` Eli Zaretskii
2022-06-22 1:58 ` Duncan Findlay via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-22 13:02 ` Eli Zaretskii
2022-06-22 15:37 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8t1rhtt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55883@debbugs.gnu.org \
--cc=duncf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.