From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Date: Sat, 26 Nov 2022 21:45:19 +0200 Message-ID: <83v8n1qz3k.fsf@gnu.org> References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> <83ilj1srma.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20586"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58877@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 26 20:46:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oz186-0005CV-RB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Nov 2022 20:46:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oz17t-0007R2-Ku; Sat, 26 Nov 2022 14:46:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz17o-0007Mp-QD for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 14:46:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oz17k-0007yz-JT for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 14:46:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oz17i-0006TS-8X for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 14:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 19:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166949190524861 (code B ref 58877); Sat, 26 Nov 2022 19:46:02 +0000 Original-Received: (at 58877) by debbugs.gnu.org; 26 Nov 2022 19:45:05 +0000 Original-Received: from localhost ([127.0.0.1]:41492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz16m-0006Sv-La for submit@debbugs.gnu.org; Sat, 26 Nov 2022 14:45:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz16k-0006SF-8x for 58877@debbugs.gnu.org; Sat, 26 Nov 2022 14:45:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz16e-0007f0-Ut; Sat, 26 Nov 2022 14:44:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n5VsdGjLoYtasJftUQrzXotQxwj9FcZ8IiOuZhcTUg0=; b=Vx0/KBkF9fTC 26h4Cb5uVUcB9ull1FF6I01QpVdjdFNTwt/fjR90z6OfVPbA29QFGeS3Kxx3RrHB3GPckhnjidgXo 6G3ALRxgAlEMQFzyENvEzlgWbxufdhcapjhK/B0cU3QZHtwdpQn/js1vbR72bPW9Ne+waWyfkdRRI JFySmkJRnln7IlUwvFJwdqeFGhYVsr3eYW/ab6oQVzPWcRZyLgeiODx1XaWhTszeDirTdtmFIdZcv LDOvp9xbVRhLlQudTSvffgp2a6IdeUzwv/Tkj0VV3V6wzfbMEf6WTfP1GmM2XJ6P0n8lN8JlYCoY2 OWe8at05UgGgobP87pjMVw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz16c-0005LI-Aj; Sat, 26 Nov 2022 14:44:54 -0500 In-Reply-To: (message from Jim Porter on Sat, 26 Nov 2022 11:04:48 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249134 Archived-At: > Date: Sat, 26 Nov 2022 11:04:48 -0800 > Cc: 58877@debbugs.gnu.org > From: Jim Porter > > > I think you need to modify the tests to ensure the server file is created in > > a temporary directory. And keep in mind that the variable which affects > > that is different depending on whether server-use-tcp is or isn't non-nil. > > Hm, I'm surprised the tests failed again for you then. Both of the > patches I posted to fix the tests set the 'server-name' to a (hopefully) > unique value. > > Still, I think it's a good idea to use a temporary directory to hold the > server file, so here's a patch that does that. I've tried this patch > with a production Emacs server running at the same time in several > different configurations (with 'server-use-tcp' on and off, and with > --daemon), and the tests all pass locally for me on GNU/Linux. Still fails, and here's why: Client output: d:\gnu\git\emacs\trunk\lib-src\emacsclient.exe: unrecognized option '--socket-name' Try 'd:\gnu\git\emacs\trunk\lib-src\emacsclient.exe --help' for more information Process d:/gnu/git/emacs/trunk/lib-src/emacsclient exited abnormally with code 1 There's no --socket-name switch on MS-Windows; you need to use --server-file instead. If I change server-tests/start-client to use --server-file, the next problem rears its ugly head: Client output: *ERROR*: Not using an ASCII terminal now; cannot make a new ASCII frame Process d:/gnu/git/emacs/trunk/lib-src/emacsclient exited abnormally with code 1 This is because emacsclient on Windows cannot create new terminal frames, only new GUI frames, unless Emacs was started as "emacs -nw". Why do these tests need TTY frames? Btw, with the above changes, only 3 tests fail: 3 unexpected results: FAILED server-tests/emacsclient/create-frame FAILED server-tests/server-force-stop/keeps-frames FAILED server-tests/server-start/stop-prompt-with-client So this is progress, thanks.