From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: stephen.berman@gmx.net, 59802@debbugs.gnu.org
Subject: bug#59802: 30.0.50; Checkbox button not rendered
Date: Tue, 13 Dec 2022 18:40:51 +0200 [thread overview]
Message-ID: <83v8mfntnw.fsf@gnu.org> (raw)
In-Reply-To: <87zgbrb7oj.fsf@ledu-giraud.fr> (message from Manuel Giraud on Tue, 13 Dec 2022 17:16:28 +0100)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: stephen.berman@gmx.net, 59802@debbugs.gnu.org
> Date: Tue, 13 Dec 2022 17:16:28 +0100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> [...]
>
> > I'm not sure I understand the reason for "else if". Isn't possible
> > that both conditions could be true?
>
> True for both conditions is unlikely because we are into a "if (! (0 <
> viewbox_width && 0 < viewbox_height))" so either viewbox_height is zero
> or viewbox_width is zero.
Perhaps this means you need to reshuffle the code so that the case
where both dimensions are non-zero comes the first. Then you will
have fewer negations in the conditions and the code will be easier to
read and understand.
Thanks.
next prev parent reply other threads:[~2022-12-13 16:40 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-03 10:40 bug#59802: 30.0.50; Checkbox button not rendered Manuel Giraud
2022-12-03 11:29 ` Eli Zaretskii
2022-12-03 14:47 ` Manuel Giraud
2022-12-03 17:44 ` Eli Zaretskii
2022-12-03 18:16 ` Manuel Giraud
2022-12-03 18:22 ` Eli Zaretskii
2022-12-03 18:24 ` Manuel Giraud
2022-12-03 18:49 ` Eli Zaretskii
2022-12-03 21:32 ` Manuel Giraud
2022-12-04 7:02 ` Eli Zaretskii
2022-12-09 12:26 ` Manuel Giraud
2022-12-09 12:35 ` Eli Zaretskii
2022-12-09 13:41 ` Stephen Berman
2022-12-09 14:07 ` Manuel Giraud
2022-12-09 14:14 ` Stephen Berman
2022-12-10 13:49 ` Eli Zaretskii
2022-12-10 16:24 ` Stephen Berman
2022-12-10 17:04 ` Eli Zaretskii
2022-12-10 17:57 ` Manuel Giraud
2022-12-10 18:38 ` Eli Zaretskii
2022-12-11 13:12 ` Stephen Berman
2022-12-11 14:47 ` Eli Zaretskii
2022-12-11 15:54 ` Eli Zaretskii
2022-12-11 22:40 ` Stephen Berman
2022-12-12 17:42 ` Eli Zaretskii
2022-12-12 23:38 ` Stephen Berman
2022-12-12 12:33 ` Manuel Giraud
2022-12-12 16:56 ` Manuel Giraud
2022-12-12 17:25 ` Stephen Berman
2022-12-12 17:38 ` Eli Zaretskii
2022-12-13 9:21 ` Manuel Giraud
2022-12-13 10:16 ` Stephen Berman
2022-12-13 12:49 ` Eli Zaretskii
2022-12-13 16:16 ` Manuel Giraud
2022-12-13 16:40 ` Eli Zaretskii [this message]
2022-12-13 17:15 ` Manuel Giraud
2022-12-13 17:36 ` Eli Zaretskii
2022-12-16 8:27 ` Manuel Giraud
2022-12-16 15:51 ` Eli Zaretskii
2022-12-16 16:09 ` Manuel Giraud
2022-12-09 13:57 ` Manuel Giraud
2022-12-10 13:47 ` Eli Zaretskii
2022-12-10 14:26 ` Manuel Giraud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8mfntnw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=59802@debbugs.gnu.org \
--cc=manuel@ledu-giraud.fr \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.