From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60168: 28.2; Doc string of `face-spec-recalc' Date: Sun, 18 Dec 2022 11:01:12 +0200 Message-ID: <83v8m9f5lz.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60168@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 18 10:02:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6pZ0-0002FP-Rw for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Dec 2022 10:02:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6pYf-0003eI-RK; Sun, 18 Dec 2022 04:02:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6pYY-0003dk-Kt for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 04:02:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6pYY-0000PR-Aw for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 04:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6pYY-0003ie-64 for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 04:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2022 09:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60168 X-GNU-PR-Package: emacs Original-Received: via spool by 60168-submit@debbugs.gnu.org id=B60168.167135407314274 (code B ref 60168); Sun, 18 Dec 2022 09:02:02 +0000 Original-Received: (at 60168) by debbugs.gnu.org; 18 Dec 2022 09:01:13 +0000 Original-Received: from localhost ([127.0.0.1]:60983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6pXl-0003i9-9g for submit@debbugs.gnu.org; Sun, 18 Dec 2022 04:01:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6pXj-0003hy-Kh; Sun, 18 Dec 2022 04:01:11 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6pXe-0000M9-0K; Sun, 18 Dec 2022 04:01:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=o1P7gPRhW6sNAp1DuU4rC4+/Q825PiYKgH9oJiuGG74=; b=qdl6ZOkXbRG0 iVv+P7tahzKuhbrJ86bH/aoTyyt21UYLHYekj7AJKsX5fSAlxhlcnjXGWQQRM1pid/8PjU+XbcYjn CD9It9eForoMsx8/rzSn2BS7d6Jsp5ja4rK7CDoir7YwFFIMj0wFmEdIoCeMXZL/CyOBNQPN9rUHk STbmU7pG4B0GJrEBW2jyj4lOVaDJV6h9xkOA5CIM3jWWrFqyoAGB5cK2wbd/+QNn0cznDWzDW8xx8 R/+YM3jSEOUsKgLF1IIbvpoo+GdnhYPWv+GmKyJwX5xuhJy/Pvj+XRUtYNjEKnCccWuRVOcPzfyTr CIa8FM1RkDW2VrmfB4xbJw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6pXd-0000Hu-Cf; Sun, 18 Dec 2022 04:01:05 -0500 In-Reply-To: (message from Drew Adams on Sat, 17 Dec 2022 20:57:48 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251340 Archived-At: tags 60168 notabug wontfix close 60168 thanks > From: Drew Adams > Date: Sat, 17 Dec 2022 20:57:48 +0000 > > I don't understand this doc string. You aren't supposed to, unless you are hacking on the face-related code (in which case the doc string is crystal clear). > And lest someone claim that this is just a "helper" function or > "internal": this is the meat of what `face-spec-set' does. If this > isn't described here then it should be described for `face-spec-set'. face-spec-set has its own doc string that explains what it does. Its doc string doesn't reference face-spec-recalc. The "meat" you mention is basically internal implementation details of how face spec is calculated and applied, something that doesn't belong to doc strings. If you have specific questions needed to understand how to define and use faces in Lisp programs, please ask those specific questions (probably in another thread). Or if you have specific questions regarding the face implementation and face spec (re-)calculation, please ask specific questions on emacs-devel. > (And in any case, the doc string here needs to be fixed or removed.) I disagree. There's no bug here that I can see. Closing.