From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 60819-done@debbugs.gnu.org
Subject: bug#60819: 28.2; `ls-lisp.el' regression introduced in Emacs 26
Date: Sun, 15 Jan 2023 10:55:49 +0200 [thread overview]
Message-ID: <83v8l85g8a.fsf@gnu.org> (raw)
In-Reply-To: <CO6PR10MB547332DA406B6FC38C8186C9F3C39@CO6PR10MB5473.namprd10.prod.outlook.com> (message from Drew Adams on Sat, 14 Jan 2023 22:28:36 +0000)
> From: Drew Adams <drew.adams@oracle.com>
> Date: Sat, 14 Jan 2023 22:28:36 +0000
>
> In all Emacs releases prior to Emacs 26, if you use command `dired' with
> an input directory name that has wildcards and ends with a slash,
> e.g. c:/foo/bar/*b*/, the command simply ignores the trailing slash and
> correctly gives you a listing of all files and dirs in c:/foo/bar/ whose
> names contain a b character.
>
> Starting with Emacs 26, such input raises an error. IMO it should not.
>
> Other than that, the error message is anyway inappropriate: "No files
> matching regexp".
I fixed the message to say "No files matching wildcard" instead.
> In general, the character / in a glob pattern cannot be matched by a
> wildcard. E.g., Wikipedia says "Normally, the path separator character
> (/ on Linux/Unix, MacOS, etc. or \ on Windows) will never be matched."
> and Linux man page glob(7) says "A '/' in a pathname cannot be matched
> by a '?' or '*' wildcard, or by a range like "[.-0]"."
This is incorrect. A wildcard like "*b*/" should expand to the list
of directories whose names match "*b*", whereas "*b*" should expand to
the list of files _and_ directories with matching names. This is how
Dired behaves on Posix platforms (where such an expansion is done by
the 'ls' program), and we want a similar behavior with ls-lisp.
So I've now made ls-lisp on the emacs-29 branch behave like that: a
wildcard that ends in a slash is expanded to the list of matching
directories. And with that, I'm closing this bug.
next prev parent reply other threads:[~2023-01-15 8:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 22:28 bug#60819: 28.2; `ls-lisp.el' regression introduced in Emacs 26 Drew Adams
2023-01-15 8:55 ` Eli Zaretskii [this message]
2023-01-15 17:04 ` Drew Adams
2023-01-15 17:25 ` Eli Zaretskii
2023-01-15 17:45 ` Visuwesh
2023-01-15 18:16 ` Eli Zaretskii
[not found] ` <87r0vvpqac.fsf@gmail.com>
2023-01-15 22:10 ` Drew Adams
2023-01-16 4:13 ` Visuwesh
2023-01-16 13:44 ` Eli Zaretskii
[not found] ` <handler.60819.D60819.167377296010937.notifdone@debbugs.gnu.org>
[not found] ` <jwv1qbxhlfc.fsf-monnier+emacs@gnu.org>
2023-12-20 23:39 ` bug#60819: closed (Re: bug#60819: 28.2; `ls-lisp.el' regression introduced in Emacs 26) Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8l85g8a.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60819-done@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.