From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 60897@debbugs.gnu.org, epg@pretzelnet.org
Subject: bug#60897: 29.0.60; vc-revert fails to revert buffer
Date: Mon, 23 Jan 2023 15:24:05 +0200 [thread overview]
Message-ID: <83v8kxidu2.fsf@gnu.org> (raw)
In-Reply-To: <86v8kx3czh.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 23 Jan 2023 09:51:30 +0200)
> From: Juri Linkov <juri@linkov.net>
> Cc: epg@pretzelnet.org, 60897@debbugs.gnu.org
> Date: Mon, 23 Jan 2023 09:51:30 +0200
>
> >> > (defun vc-resynch-buffer (file &optional keep noquery reset-vc-info)
> >> > "If FILE is currently visited, resynch its buffer."
> >> > + (unless (file-name-absolute-p file)
> >> > + (setq file (expand-file-name file (vc-root-dir))))
> >> > (if (string= buffer-file-name file)
> >> > (vc-resynch-window file keep noquery reset-vc-info)
> >> > (if (file-directory-p file)
> >>
> >> Eli, is this ok for the emacs-29 branch? I'm unsure because
> >> vc-resynch-buffer is used in too many places, so this change
> >> is not localized to vc-revert.
> >
> > You could use the expanded file name only for the purposes of the
> > string= call, no? Then the effect of this change would be very local
> > and thus safer.
>
> There is another string= call that fails inside vc-resynch-window
> called from vc-resynch-buffer.
How about replacing string= in these two cases with something smarter,
which would expand-file-name? Comparing file names as simple strings
is wrought with trouble anyway.
next prev parent reply other threads:[~2023-01-23 13:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 1:09 bug#60897: 29.0.60; vc-revert fails to revert buffer Eric Gillespie
2023-01-18 17:29 ` Juri Linkov
2023-01-21 0:54 ` Eric Gillespie
2023-01-22 17:12 ` Juri Linkov
2023-01-22 17:17 ` Juri Linkov
2023-01-22 19:50 ` Eli Zaretskii
2023-01-23 7:51 ` Juri Linkov
2023-01-23 13:24 ` Eli Zaretskii [this message]
2023-01-24 17:46 ` Juri Linkov
2023-01-24 18:06 ` Eli Zaretskii
2023-01-24 18:18 ` Juri Linkov
2023-01-24 18:36 ` Eli Zaretskii
2023-01-24 18:49 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8kxidu2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60897@debbugs.gnu.org \
--cc=epg@pretzelnet.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.