all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: abdo.haji.ali@gmail.com, 61102@debbugs.gnu.org
Subject: bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once
Date: Thu, 02 Feb 2023 19:06:00 +0200	[thread overview]
Message-ID: <83v8kkvvyf.fsf@gnu.org> (raw)
In-Reply-To: <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> (message from martin rudalics on Thu, 2 Feb 2023 16:04:52 +0100)

> Date: Thu, 2 Feb 2023 16:04:52 +0100
> Cc: 61102@debbugs.gnu.org
> From: martin rudalics <rudalics@gmx.at>
> 
>  > Martin, any comments on this?  FWIW, I'm not sure this is a bug, but
>  > maybe I'm missing something.
> 
> The doc-string of 'with-selected-window' says that:
> 
>    "It does not alter the buffer list ordering."
> 
> and the Elisp manual is more explicit by saying that
> 
>    "The ordering of recently selected windows and the buffer list remain
>     unchanged unless you deliberately change them within FORMS; for
>     example, by calling ‘select-window’ with argument NORECORD ‘nil’.
>     Hence, this macro is the preferred way to temporarily work with
>     WINDOW as the selected window without needlessly running
>     ‘buffer-list-update-hook’."
> 
> The one message the OP sees comes from this call in
> 'set-window-configuration'
> 
> 	select_window (data->current_window, Qnil, false);
> 
> 'set-window-configuration' itself is called by 'save-window-excursion'.

So do you agree with me that there's no bug here?





  reply	other threads:[~2023-02-02 17:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 18:29 bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once Al Haji-Ali
2023-02-02 10:22 ` Eli Zaretskii
2023-02-02 15:04   ` martin rudalics
2023-02-02 17:06     ` Eli Zaretskii [this message]
2023-02-02 18:16       ` martin rudalics
2023-02-02 19:56         ` Eli Zaretskii
2023-02-02 17:08     ` Al Haji-Ali
2023-02-02 18:17       ` martin rudalics
2023-02-02 21:21         ` Al Haji-Ali
2023-02-03  8:33           ` martin rudalics
2023-02-03 11:49             ` Al Haji-Ali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83v8kkvvyf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61102@debbugs.gnu.org \
    --cc=abdo.haji.ali@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.