From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: 62675@debbugs.gnu.org
Subject: bug#62675: 29.0.60; emoji-zoom-increase interacts badly with faces
Date: Wed, 05 Apr 2023 11:45:35 +0300 [thread overview]
Message-ID: <83v8iasonk.fsf@gnu.org> (raw)
In-Reply-To: <87y1n6hj7r.fsf@gmail.com> (message from Robert Pluim on Wed, 05 Apr 2023 09:38:32 +0200)
> From: Robert Pluim <rpluim@gmail.com>
> Date: Wed, 05 Apr 2023 09:38:32 +0200
>
>
> --begin--
> emacs -Q
> C-p C-p
> C-x 8 e + + + +
> C-u C-x =
> --end--
>
> Visually, this does the right thing: the ';' has its height increased,
> but the text properties look like this:
>
> face ((:height 1.1) font-lock-comment-delimiter-face :height 1.3310000000000004)
> fontified t
> rear-nonsticky t
>
> Thatʼs not a valid 'face property, unless Iʼm misreading (info
> "(elisp) Special Properties"), plus the ':height 1.331' bit is wrong,
> thatʼs (expt 1.1 3), not (expt 1.1 4). Yet it works, the height has
> been increased.
The first "+" doesn't increase the height, though.
> Is this a bug in our interpretation of 'face properties?
Face properties can be specified in many strange ways, and the fact
that some invalid specifications seem to "work" doesn't mean we have a
bug, it just means some invalid faces fall through the cracks.
> I can fix the code in `emoji-zoom-increase' to produce something like
>
> ((:height 1.4641000000000004) font-lock-comment-delimiter-face)
>
> instead
Please do, and thanks. We don't need to understand why some bug seems
to work, it is enough to fix the bug.
next prev parent reply other threads:[~2023-04-05 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 7:38 bug#62675: 29.0.60; emoji-zoom-increase interacts badly with faces Robert Pluim
2023-04-05 8:45 ` Eli Zaretskii [this message]
2023-04-05 9:12 ` Robert Pluim
2023-04-05 9:54 ` Eli Zaretskii
2023-04-05 11:55 ` Robert Pluim
2023-04-05 12:08 ` Eli Zaretskii
2023-04-05 13:53 ` Robert Pluim
2023-04-06 11:38 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8iasonk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=62675@debbugs.gnu.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.