From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Bug? Date: Fri, 05 May 2023 07:41:14 +0300 Message-ID: <83v8h7jsph.fsf@gnu.org> References: <875y9aciir.fsf.ref@yahoo.com> <875y9aciir.fsf@yahoo.com> <9DC42D1F-2061-48ED-932B-9704538356C8@acm.org> <380B9B5B-9FB9-4A99-830B-117A33519D3A@acm.org> <838re5mzcu.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="947"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mattiase@acm.org, emacs-devel@gnu.org, luangruo@yahoo.com To: Shynur Xie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 05 06:40:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1punFH-000064-C7 for ged-emacs-devel@m.gmane-mx.org; Fri, 05 May 2023 06:40:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1punF3-0001h8-1d; Fri, 05 May 2023 00:40:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1punF1-0001gz-4k for emacs-devel@gnu.org; Fri, 05 May 2023 00:40:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1punF0-0006Tc-Q5; Fri, 05 May 2023 00:40:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=M2/+iYupwT7Otu9oMvzwuUrQFjjCj1ZOZixSm0u+qwE=; b=dVGPxO9RWbOQ BrXLpLLoa8Q25Q9c/Sij/DDQqWyHD4ynnYw3105p1CTJBPqUfuWoz1XNaCi96mH13ugANMEPgGgxv VxnQwgzjsdd43vfzFJV4IwP3gILjBtrNXBYbSuHcNFxWjiTskjpl/o4iATEy+mA7x2nMHeJpzn6fo rIjtxtrL9UE2x4jHxaCqScTOOgNzXT/50p5Ce7cWFcL29PIIXITmje8GygotVSRkVy7Cp4e0niMWx /VFPNXg8KqQLDGkVefuwKeF4S1ycN9mjZXy+ZKGnuEmTqTDOEDmLPyYZcEFPlc4itWi8Wfgr7OifR yI8m7FPiJz0fPkk4m0NtsQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1punF0-00061a-8j; Fri, 05 May 2023 00:40:22 -0400 In-Reply-To: (message from Shynur Xie on Thu, 4 May 2023 20:57:36 +0000) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305848 Archived-At: > From: Shynur Xie > CC: "emacs-devel@gnu.org" , "luangruo@yahoo.com" > > Date: Thu, 4 May 2023 20:57:36 +0000 > msip_labels: > > >> I also noticed that when the closing bracket is comprised of > >> multiple characters, only the first character is high-lit using > >> that face. For example, in shell-script-mode, when `esac` matches > >> `case`, only the `c` in `case` is high-lit. Perhaps this new > >> feature isn't quite finished yet. > > > > Shynur, could you please fix this deficiency? > > Patch is attached. To highlight the entire matched opening delimiter: > (show-paren-mode) > (setq blink-matching-paren-offscreen t > show-paren-context-when-offscreen t) Thanks, but I don't think I understand: didn't you tell that the problem reported above is not a bug, but the expected and long-time behavior of blink-matching-paren? If so, what exactly does this patch fix? > I also changed the function `blink-paren-open-paren-line-string': > Originally, say here's a shell script > case case > ... <- many lines > esac* <- cursor here > both `blink-matching-open' and `show-paren-mode' emitted "case c"; > Now `show-paren-mode' instead emits "case case" if > `show-paren-context-when-offscreen' is t. This seems to be about show-paren-mode, not about blink-matching-paren. Those are different, though related, features.