From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63913: [PATCH] * lisp/minibuffer.el (minibuffer-completion-help): Only ding when appropriate. Date: Sat, 10 Jun 2023 12:13:04 +0300 Message-ID: <83v8fvznmn.fsf@gnu.org> References: <834jnl4ub9.fsf@gnu.org> <831qio4z3d.fsf@gnu.org> <83bkhq2s19.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15315"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Morgan.J.Smith@outlook.com, spacibba@aol.com, 63913-done@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 10 11:14:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7uft-0003kZ-Aj for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Jun 2023 11:14:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7ufc-00074M-WE; Sat, 10 Jun 2023 05:14:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7ufa-00073o-Sg for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 05:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7ufa-0001hi-Fb for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 05:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7ufa-0002tn-BI for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 05:14:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 09:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63913 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 63913@debbugs.gnu.org, eliz@gnu.org, Morgan.J.Smith@outlook.com Original-Received: via spool by 63913-done@debbugs.gnu.org id=D63913.168638838211060 (code D ref 63913); Sat, 10 Jun 2023 09:14:02 +0000 Original-Received: (at 63913-done) by debbugs.gnu.org; 10 Jun 2023 09:13:02 +0000 Original-Received: from localhost ([127.0.0.1]:33287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7uec-0002sK-JN for submit@debbugs.gnu.org; Sat, 10 Jun 2023 05:13:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7ueZ-0002rp-H9 for 63913-done@debbugs.gnu.org; Sat, 10 Jun 2023 05:13:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7ueU-0001SV-1E; Sat, 10 Jun 2023 05:12:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=p2ukUQ8cMvfaiiKkLpFrNt75F6uJuNnOiONQsmJeNX8=; b=qYkO+mMO5sWX 5CYOquBBwQ2S1KD1QAE+t0D9oUKvUM5v6sGobP2/tu3bC4TjNxjmEh6H3GofqI3dXoDpagajPn8YB h3cf4x2Qw3uyTBdrSpnRmOEoW+8Gom/+kfiFE3QetZPBnQ22qx1twXKlGsj7pLdW8Hcggmhtzjgpa vvzEPP316VFZKwrNHr08rzt6xuOKWyjkUq981owlqeQ3DumsnzzxTgXSeMtFmXP0nsH48GnwbcDIQ x9wlz6xFRddrQ2Br/sG6Q5uznKD5SB2eJrbvPgO6kydvs9glsiZ2Bir+odCinjHC2YxhL84TtgEah 4vPnGPiktyaPdnIzcVofBw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7ueT-0007Pz-HD; Sat, 10 Jun 2023 05:12:53 -0400 In-Reply-To: (message from Stefan Monnier on Thu, 08 Jun 2023 12:54:37 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263205 Archived-At: > From: Stefan Monnier > Cc: Morgan Smith , Jimmy Aguilar Mena > , 63913@debbugs.gnu.org > Date: Thu, 08 Jun 2023 12:54:37 -0400 > > > I've added to the discussion folks that know more about this than I > > do. Stefan, Ergus: any comments to the issue or about the proposed > > patch? (I'm not sure we need to change the message when we do "ding", > > but that's a separate issue, I think.) > > The patch looks good to me. Thank you, Morgan. Thanks, installed on the emacs-29 branch, and closing the bug.