From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64642: 29.0.92; Native compiler doesn't compile dynamically bound functions. Date: Mon, 17 Jul 2023 19:06:58 +0300 Message-ID: <83v8ei7c9p.fsf@gnu.org> References: <838rbhcxg0.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13635"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acm@muc.de, 64642@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 17 18:07:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qLQlN-0003Gp-Bb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 Jul 2023 18:07:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLQl4-00050Y-0N; Mon, 17 Jul 2023 12:07:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLQku-0004xF-4p for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 12:07:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLQkY-0004xV-Ch for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 12:07:18 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qLQkX-0001Jo-Ra for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2023 12:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Jul 2023 16:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64642 X-GNU-PR-Package: emacs Original-Received: via spool by 64642-submit@debbugs.gnu.org id=B64642.16896100045043 (code B ref 64642); Mon, 17 Jul 2023 16:07:01 +0000 Original-Received: (at 64642) by debbugs.gnu.org; 17 Jul 2023 16:06:44 +0000 Original-Received: from localhost ([127.0.0.1]:50798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLQkG-0001JG-2G for submit@debbugs.gnu.org; Mon, 17 Jul 2023 12:06:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLQkB-0001Iw-Ha for 64642@debbugs.gnu.org; Mon, 17 Jul 2023 12:06:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLQk5-0004r5-0E; Mon, 17 Jul 2023 12:06:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0eWSVBlfbfnFKR5J8/ECDH9bD0AgUwx7C2xzc03ZUEE=; b=Rc/SJcCIu8sU 9MT9qcNkSTGeNh4WJtWcPdxggDq0drNhBn/rviC7G4/snLf6Y0EagCFE4UHxGQKyUsn0/PA4XD9wh rcLTJZvxt4c4miwYwetpgroeLWUaKBGzPDv1ClqYlqxsorFwMxRy9DSKSpvWD34S6sf5hNY8SO+KN Hbyetka/GX9zUAr4QJcDAQAi/QOA3o52sjQ3uKwHLXgF6brEWn6RYFjnn6yHI9uUdIeUoYia7qd0K QfWIdn8aiDhu/07itFrs8tFjgSWCVftc84i/waANeLFm0Py+bAdDSjQp/auozQBO6ZBObWg3SgM6S ftTUp6zw5e8x8OUopWfNWQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLQk3-0005Yk-Kn; Mon, 17 Jul 2023 12:06:32 -0400 In-Reply-To: (message from Andrea Corallo on Mon, 17 Jul 2023 09:42:31 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265400 Archived-At: > From: Andrea Corallo > Cc: Eli Zaretskii , 64642@debbugs.gnu.org > Date: Mon, 17 Jul 2023 09:42:31 -0400 > > >> It is unlikely that this will be fixed in Emacs 29, unless the fix is > >> so simple that will surprise me. > > > > Here is a fix. Its simplicity probably doesn't surprise you (Eli), but > > the change is entirely within one function, and a lot of the patch is > > just whitespace changes. > > > > There are no problems running make bootstrap or make check with patch in > > place. It also solves the bug; unless there are good reasons dynamically > > bound functions weren't handled. Andrea? > > Hi Alan, > > the fix LGTM thanks for the patch, I think we only need to add a test as > well to exercise this code, something like the "free-fun" test in > comp-tests.el. Alan, when the patch is ready, please install on master. Thanks.