From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Android port Date: Fri, 04 Aug 2023 15:59:47 +0300 Message-ID: <83v8dvufng.fsf@gnu.org> References: <1428589171.162865.1691134964773@mail1.libero.it> <837cqbw8df.fsf@gnu.org> <87cz039m4v.fsf@yahoo.com> <831qgjw0nj.fsf@gnu.org> <874jlf9fbr.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1144"; mail-complaints-to="usenet@ciao.gmane.io" Cc: angelo.g0@libero.it, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 04 14:59:47 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRuPD-00008k-E8 for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Aug 2023 14:59:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRuP5-0003NE-Pk; Fri, 04 Aug 2023 08:59:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRuP3-0003N0-Rg for emacs-devel@gnu.org; Fri, 04 Aug 2023 08:59:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRuP3-0006Ep-GD; Fri, 04 Aug 2023 08:59:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6ZuEjfK86EiE9T0P3VnLcC+0Bd3jEVcVfwNKaEgUsBE=; b=JQgm6q3O3ml2 7pv2XK+oJdApON6Lrz9bYkK3CoEfJRoKmPaPv+JDmGxvk0magTkysN/X7z02jeRgliW/bBNaI0LuP UBEchPhfboov7xhPcpx08qbcjPY3uHL+I9TXKMx+4DdTkkGoTIStstqAjGFAjqkMEXb9W/FHXhSSU AIHnfYoDap73qBlDgJIh5olqPtszdCNQmRC3dnRrhW91Kh0u6D8gvOMQWEX5r2GyNZX1YXl/UYWL+ LMAD82Fgqd4cmRUjfzT/ZF6OX4ODtMTQ2JT4O38qoX7ZusYP2l3oBjIuSN6Op5nS4CMJGhRtQ3Bqi HchBn3komQ3Ag9JfDDQaVw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRuP1-0002YS-Nz; Fri, 04 Aug 2023 08:59:36 -0400 In-Reply-To: <874jlf9fbr.fsf@yahoo.com> (message from Po Lu on Fri, 04 Aug 2023 20:12:24 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308288 Archived-At: > From: Po Lu > Cc: angelo.g0@libero.it, emacs-devel@gnu.org > Date: Fri, 04 Aug 2023 20:12:24 +0800 > > Eli Zaretskii writes: > > > That doesn't answer my question, AFAICT. In the current master we > > have no uses of asprintf and vasnprintf, so I asked whether it is > > needed on the branch, and if so, whether the MS-Windows build uses the > > code where these two functions are called. > > It doesn't, but vfprintf-posix actually replaces all the printf > functions, not just (vasn)printf. The replacement functions are not > necessary on Windows, however. Then TRT is to disable the build of vfprintf-posix module on Windows. > > The way to override Gnulib tests that conclude that some libc function > > should be replaced is not to override the feature test (unless that > > feature is supported, but Gnulib doesn't know about it -- which can > > only happen if we implement the library function inside Emacs). The > > way to override those is to exclude the relevant Gnulib modules from > > the Windows build via nt/gnulib-cfg.mk. > > There is already: > > OMIT_GNULIB_MODULE_vasnprintf = true > OMIT_GNULIB_MODULE_vasprintf = true > OMIT_GNULIB_MODULE_vfprintf-posix = true > > within gnulib-cfg.mk, but fudging with the feature tests is also > necessary to generate the Gnulib stdio.h header correctly; absent that, > it tries to provide definitions for its printf replacements, which does > not work. OK, then I guess there's something else at work here. In any case, the information posted by Angelo clearly shows that asprintf.c is being compiled, and that is strange if vfprintf-posix module is disabled. Maybe we also need OMIT_GNULIB_MODULE_asprintf = true ?