From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: fgunbin@fastmail.fm, 65805@debbugs.gnu.org
Subject: bug#65805: 30.0.50; quoted-insert doesn't work in zap-to-char
Date: Mon, 11 Sep 2023 14:44:12 +0300 [thread overview]
Message-ID: <83v8chq6ib.fsf@gnu.org> (raw)
In-Reply-To: <jwvh6o1fwv7.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sun, 10 Sep 2023 19:14:34 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: fgunbin@fastmail.fm, 65805@debbugs.gnu.org
> Date: Sun, 10 Sep 2023 19:14:34 -0400
>
> >> > That's because we switched to using read-from-minibuffer (via
> >> > read-char-from-minibuffer) instead of using read-char, for the dubious
> >> > benefit of being able to use history in this command, see bug#10477.
> >> > And read-from-minibuffer interprets some characters specially.
> >> > Stefan, is there a way to have this cake and eat it, too?
> >> How 'bout the patch below?
>
> Had a missing `nil`.
>
> > Is this appropriate for emacs-29?
>
> It looks fairly safe, but is it a regression in Emacs-29 or was it
> already there in Emacs-28?
It was already in Emacs 28.
> If it's not a regression in Emacs-29, I'd keep it in `master`.
OK, then please install on master and close this bug when you do.
> >> AFAICT it would also make it unnecessary to use
> >> `read-char-from-minibuffer-insert-char`.
> > Not sure I understand what are you proposing here about that function.
>
> `read-char-from-minibuffer-insert-char` is a function which just inserts
> a char and then exits the minibuffer. With my patch,
> `self-insert-command` should work as well for that.
I'm okay with making such a change, but we'd probably need a
compatibility shim if we do that? So maybe it isn't worth the hassle,
just make read-char-from-minibuffer-insert-char obsolete?
next prev parent reply other threads:[~2023-09-11 11:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 14:53 bug#65805: 30.0.50; quoted-insert doesn't work in zap-to-char Filipp Gunbin
2023-09-07 15:07 ` Eli Zaretskii
2023-09-07 16:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-07 17:13 ` Juri Linkov
2023-09-07 17:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-13 16:39 ` Juri Linkov
2023-09-13 17:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-14 6:45 ` Juri Linkov
2023-09-10 7:17 ` Eli Zaretskii
2023-09-10 23:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-11 11:44 ` Eli Zaretskii [this message]
2023-09-12 17:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8chq6ib.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65805@debbugs.gnu.org \
--cc=fgunbin@fastmail.fm \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.