From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar items Date: Mon, 11 Sep 2023 22:12:47 +0300 Message-ID: <83v8cgplqo.fsf@gnu.org> References: <87zg4d56l8.fsf@ledu-giraud.fr> <87ilaz1wol.fsf@ledu-giraud.fr> <87fs3xo13z.fsf@yahoo.com> <83zg259iwz.fsf@gnu.org> <878r9losil.fsf@ledu-giraud.fr> <83tts2scvp.fsf@gnu.org> <87cyyo28m0.fsf@ledu-giraud.fr> <83cyyorfnr.fsf@gnu.org> <87r0n4sqm8.fsf@ledu-giraud.fr> <835y4gr9ao.fsf@gnu.org> <87jzswsfmi.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24334"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, stefankangas@gmail.com, 64440@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 11 21:14:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfmMJ-00069o-EY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Sep 2023 21:14:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qfmMC-0002c7-76; Mon, 11 Sep 2023 15:14:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfmMA-0002bz-MV for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 15:13:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qfmMA-0007SF-EM for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 15:13:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qfmME-0002In-J8 for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2023 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2023 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64440 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64440-submit@debbugs.gnu.org id=B64440.16944596008792 (code B ref 64440); Mon, 11 Sep 2023 19:14:02 +0000 Original-Received: (at 64440) by debbugs.gnu.org; 11 Sep 2023 19:13:20 +0000 Original-Received: from localhost ([127.0.0.1]:54890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfmLX-0002Hk-I8 for submit@debbugs.gnu.org; Mon, 11 Sep 2023 15:13:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qfmLV-0002HX-QQ for 64440@debbugs.gnu.org; Mon, 11 Sep 2023 15:13:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qfmLL-0007L4-Eg; Mon, 11 Sep 2023 15:13:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ez2NXwsjHW76fjj5cs2qlVX5hMURlQub5KruJMZdG7M=; b=YBplefQdnS3u anrfKEBy7D8MQedqbw2JuK7Mt1CMEgLcw4hBck3OAqWZ7s/N2gK8MzrRzOIor4MXj13e094CaLMhI 6nHwimo1HOQqtekI4vB3PNNaZa5ukbPZ09dhAWjtO3zIlKii+7B9VNYAnQ+GNsgvqEcrB59Vk8SvR 0L/GrcMtv5ws2yGo3vLOhdSRz0yTt/R4GcjYMhpHbuHOA7ITQ+fFk/gZsPC7MYRm9rn/t0eTyBaaF fAnXoUiTcxm9MiGArMV/0VhVtNdAwlHbJfdtvHXehhexLLOjn1HONkOYLzINwBEqKjDA5XM+bV9zb xKWpXNNjECddWdnU/9x2RA==; In-Reply-To: <87jzswsfmi.fsf@ledu-giraud.fr> (message from Manuel Giraud on Mon, 11 Sep 2023 20:56:37 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270078 Archived-At: > From: Manuel Giraud > Cc: luangruo@yahoo.com, stefankangas@gmail.com, 64440@debbugs.gnu.org > Date: Mon, 11 Sep 2023 20:56:37 +0200 > > Eli Zaretskii writes: > > [...] > > > Thanks. That's what I imagined we have there. So I guess considering > > that a string ends where is SCHARS end is reasonable. > > > > But note that the above means you could also detect where each item > > ends by looking for the glyph whose string position is -1. So maybe > > add an assertion there that the glyph after the last character has its > > position as -1, in case we could have some complications there with > > double-width characters or something. > > What do you think of this: > > + /* Convert to pixels bounds. */ > + row = MATRIX_ROW (w->current_matrix, *vpos); > + *x_start = 0; > + for (i = 0; i < *h_start; ++i) > + *x_start += row->glyphs[TEXT_AREA][i].pixel_width; > + > + *x_end = *x_start; > + for (i = *h_start; CHARPOS (row->glyphs[TEXT_AREA][i]) != -1; ++i) > + *x_end += row->glyphs[TEXT_AREA][i].pixel_width; That's OK, but I think we should also make sure 'i' never exceeds the value row->used[TEXT_AREA] - 1. This is only important for the last item, but still. And I would also add an assertion that row->reversed_p is false. We don't currently support R2L menu bars, but if we ever do, the above loops should go backwards in such glyph rows.