From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] python.el: Returning inferior Python output without inhibiting it Date: Mon, 02 Oct 2023 19:10:50 +0300 Message-ID: <83v8bp6m45.fsf@gnu.org> References: <87msx2ib0c.fsf@gmail.com> <83fs2u8ehy.fsf@gnu.org> <87jzs6hz26.fsf@gmail.com> <837co58t8h.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2397"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jackkamm@gmail.com, emacs-devel@gnu.org To: kobarity Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 02 18:11:47 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qnLWL-000097-Sm for ged-emacs-devel@m.gmane-mx.org; Mon, 02 Oct 2023 18:11:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnLVV-0004Ts-LL; Mon, 02 Oct 2023 12:10:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnLVT-0004RK-6D for emacs-devel@gnu.org; Mon, 02 Oct 2023 12:10:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnLVR-00010N-NZ; Mon, 02 Oct 2023 12:10:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UvtW2KMp/pwGL1NbICKwaFrdSED33kE9wlJ0LJhrKIo=; b=nbiiRKzeWv3K U1e+Dx4LWCU33KRV1n07ST2o0QRvCfukfdv90NiBozZjxPWBu5dMNU+BbU/1+ivP/FZ5zdMzmKDON sqoeJy6tGtigToc6bVYTYjGO+1HOVrT3wy4WVvrKF0L/z6eazmLcdVQGk4vVcAm6IxhQA5YQthlkQ D+e0KIyeu2YqLo9Qba3X2NawzaKkgDY5cDZZPbbKI8KaaF419D0DX9A8pyPpF/QPrj36+ksVdJ/ko QsyJuPpKIWVjqNx63vMgvwl74wGfKjLX0b/uAHBjfSsYzns8mNQ+s5AZj/56tfsuDeG1LVujXmn6a +tonbi3U9paSMRB8y4AhSg==; In-Reply-To: (message from kobarity on Mon, 02 Oct 2023 21:42:43 +0900) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311239 Archived-At: > Date: Mon, 02 Oct 2023 21:42:43 +0900 > From: kobarity > Cc: Jack Kamm , > emacs-devel@gnu.org > > > Eli Zaretskii wrote: > > > > > From: Jack Kamm > > > Cc: emacs-devel@gnu.org > > > Date: Sun, 01 Oct 2023 13:23:29 -0700 > > > > > > Eli Zaretskii writes: > > > > > > > I think instead of renaming (which then requires us to add an obsolete > > > > alias), it would be better to leave python-shell-send-string-no-output > > > > available, but just make it a thin wrapper around > > > > python-shell-send-string-return-output (which I would suggest to name > > > > python-shell-send-string-maybe-output instead). This way, we don't > > > > annoy Lisp programs that use python-shell-send-string-no-output with > > > > obsolescence warnings. > > > > > > Thanks for the feedback -- I've updated the patch accordingly (attached). > > > > Thanks. kobarity, any comments or suggestions? > > I agree with leaving `python-shell-send-string-no-output' as it is. > The updated patch looks good to me. Thanks. I will wait for a few days to give others a chance to chime in and post comments or suggestions, and will install this after that, barring any objections.