From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67310: [PATCH] Include the project--list as history when prompting for a project Date: Sat, 25 Nov 2023 17:57:10 +0200 Message-ID: <83v89pbzc9.fsf@gnu.org> References: <421e3ea8-d150-566e-f645-cbf1ccbcba61@gutov.dev> <81b6ed58-3fdc-3b5a-41a9-84d66475d5f1@gutov.dev> <5c3eb6a1-38da-8af4-419a-e0567b163e3a@gutov.dev> <83bkblgeja.fsf@gnu.org> <83edgedy1j.fsf@gnu.org> <96636783-62bb-0bb1-ecb5-c510630402e3@gutov.dev> <83zfz1c4am.fsf@gnu.org> <7a354d33-54b6-cc51-f9f4-58ee14380852@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25939"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67310@debbugs.gnu.org, sbaugh@janestreet.com, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 16:58:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6v2l-0006Tb-9p for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 16:58:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6v2c-0004Zj-Rl; Sat, 25 Nov 2023 10:57:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6v2b-0004ZY-JN for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 10:57:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6v2b-0005OK-7k for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 10:57:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6v2g-00045v-B8 for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 10:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 15:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67310 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67310-submit@debbugs.gnu.org id=B67310.170092785515695 (code B ref 67310); Sat, 25 Nov 2023 15:58:02 +0000 Original-Received: (at 67310) by debbugs.gnu.org; 25 Nov 2023 15:57:35 +0000 Original-Received: from localhost ([127.0.0.1]:40062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6v2E-000454-LW for submit@debbugs.gnu.org; Sat, 25 Nov 2023 10:57:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6v2C-00044p-LC for 67310@debbugs.gnu.org; Sat, 25 Nov 2023 10:57:33 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6v21-0005MA-17; Sat, 25 Nov 2023 10:57:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=79f+Msf9x3gpHxZ8XebaFqOrwPyo/UB83QQAzewOJKM=; b=BZOjwbXJWTEJ W1X+shN/RNVM0olqX3/vNyPOMxpZwOibNOoaeEDBgrrrW206eapgYoPS16gMAPAY8B/5BFMQfnN/H e7AMht5octnpyEVeyUG6x13byraZP5EWAUctFsDm/ZI728++7GNuht9IgiP57ddctmcuN/CfsYxFU HGU1FitPas5iUnlXclz2zim9VJwuVdo2BOYUtkRHfe1NRRaqwMV8g3iTvg4Vx8dEqhh7bkDxqnl7P 0fpA0yfYTrVTrQvmo5yu+XSiylba486ND3QJwbcXGbPjrB9jJ0hq86m5yirwcgsGnXjKehMoYML8d uQlo69AxKfUukgWitfB9qg==; In-Reply-To: <7a354d33-54b6-cc51-f9f4-58ee14380852@gutov.dev> (message from Dmitry Gutov on Sat, 25 Nov 2023 17:06:06 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274995 Archived-At: > Date: Sat, 25 Nov 2023 17:06:06 +0200 > Cc: sbaugh@janestreet.com, 67310@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > On 25/11/2023 16:10, Eli Zaretskii wrote: > >> Date: Sat, 25 Nov 2023 16:05:03 +0200 > >> Cc:sbaugh@janestreet.com,67310@debbugs.gnu.org,juri@linkov.net > >> From: Dmitry Gutov > >> > >>> I generally request and expect people not to make unnecessary changes, > >>> since doing that makes forensics harder: you see changes which don't > >>> change the code's semantics, and need to waste time studying such > >>> "changes" and deciding that they are no-ops. > >>> > >>> Please everyone keep this in mind when you make changes. > >> In general we don't frown in making minor cosmetic changes in the same > >> area as major meaningful changes are done. > > Yes, if the changes are for the better. In this case, they seem to be > > due to someone's personal stylistic preferences, so their value is > > questionable at best. > > I generally allow stylistic preferences when they don't run counter to > mine. That's better for contributors' morale, for one thing. I suggest what I think is a better principle: the stylistic preferences of the original author always take precedence. This is better both for the original author's morale (as in "something will always be left of my contribution"), and for forensics, as I explained. And I don't think this should hurt contributors' morale, since they will know that their preferences in the code they introduce will be kept for as long as the code is relevant, and not overwritten the next day.