From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Thu, 30 Nov 2023 08:00:20 +0200 Message-ID: <83v89j6arv.fsf@gnu.org> References: <87il7ib6cu.fsf@posteo.net> <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de> <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de> <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de> <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de> <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de> <87h6mcr8ol.fsf@posteo.net> <87r0l73029.fsf@web.de> <877cmdx8ud.fsf@posteo.net> <87sf50s1gh.fsf@posteo.net> <83o7ficesp.fsf@gnu.org> <878r6leh9d.fsf@posteo.net> <83il5pbnmh.fsf@gnu.org> <87zfz1cz7s.fsf@posteo.net> <83bkbc7j1o.fsf@gnu.org> <8734wov2wv.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11705"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, 66394@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 30 07:01:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r8a6z-0002u0-1F for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 30 Nov 2023 07:01:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8a6m-0000dc-Gh; Thu, 30 Nov 2023 01:01:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8a6Y-0000Vy-UB for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 01:00:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8a6Y-0004Xj-FY for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 01:00:54 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r8a6g-00042q-0W for bug-gnu-emacs@gnu.org; Thu, 30 Nov 2023 01:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Nov 2023 06:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.170132405415523 (code B ref 66394); Thu, 30 Nov 2023 06:01:01 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 30 Nov 2023 06:00:54 +0000 Original-Received: from localhost ([127.0.0.1]:51997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8a6Y-00042J-6Y for submit@debbugs.gnu.org; Thu, 30 Nov 2023 01:00:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r8a6W-00041w-Bb for 66394@debbugs.gnu.org; Thu, 30 Nov 2023 01:00:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8a6I-0004X6-Cx; Thu, 30 Nov 2023 01:00:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sdImzQRiyZK8fUQ1Il4dFvQF/ILFQXpf9iNd6Vm4a7o=; b=QJVw0s1JG9Ka jXsu+F0sO4JbpddfekBKt8Gl94aYrjlHUk3M2XXvD/XYXDTW3ocjWguVLlsy5GFvEFOuhjUTI2Hrz nPZr4OsKcAs20Q2B35LCUj5MBlrZXlIM5Il0sjSu/geKeredmzXoQjfUS+oMhfm4dwqOYFdHeiNT0 yxyG6rzFUSdc8qwQs4UiiQScwUK99wxbHvIZj48LKwENE8eb9YQMqtW7bkiCJX6CBEC0SzIrLhwZz CtJFRelNtZRb65Or8Tuuh+VreWwCzn6onoVT5wG1C2eK6JS4FiTnn9laubQZ4f17uYKz3b2TniYuq kYAyWTeyLMDMjrsygrUl7g==; In-Reply-To: <8734wov2wv.fsf@posteo.net> (message from Thierry Volpiatto on Wed, 29 Nov 2023 18:18:40 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275266 Archived-At: > From: Thierry Volpiatto > Cc: monnier@iro.umontreal.ca, michael_heerdegen@web.de, > stefankangas@gmail.com, 66394@debbugs.gnu.org > Date: Wed, 29 Nov 2023 18:18:40 +0000 > > Eli Zaretskii writes: > > > The response "a" to the "Point to register:" question is something I > > needed to type; > > Of course we are using now read-from-minibuffer and the test is related > to read-key not quitting with C-g > > > previously the test never asked any questions (and it shouldn't, > > AFAIU). > > Yes, it shouldn't, but now we are using a real minibuffer, is this test > really needed? > It is like if you had to make tests in all functions using > read-from-minibuffer to check if it quit properly with C-g (it does of course). Can we have a similar issue with read-from-minibuffer? Not with C-g, but with some other invalid input, like some function key or non-ASCII character or invalid character codepoint? If this cannot happen, then perhaps the whole test file should be removed? Anyway, I trust you to do what is needed here, I just want the test suite to keep running successfully, and I don't have time to work on this myself. TIA. > ALSO: I intentionally leave register-preview-delay defcustom with a FIXME > comment, do you want to remove it? It is not used anymore now AFAIK. This should be declared obsolete, with an explanation that it is no longer used, and a note about that should be added to NEWS, in the incompatible changes section. Then we can remove the FIXME. Thanks.