From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67709: 29.1.50; [patch] missing indent rule for parameter list in csharp-ts-mode Date: Sat, 16 Dec 2023 13:39:58 +0200 Message-ID: <83v88yml4h.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17331"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67709@debbugs.gnu.org To: Jacob Leeming , Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 16 12:41:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rET2n-0004J7-C0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Dec 2023 12:41:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rET2V-00051e-3C; Sat, 16 Dec 2023 06:41:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rET2T-0004zt-Nv for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 06:41:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rET2T-0006RC-Fg for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 06:41:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rET2T-0000XN-IK for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 06:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Dec 2023 11:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67709 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67709-submit@debbugs.gnu.org id=B67709.17027268602050 (code B ref 67709); Sat, 16 Dec 2023 11:41:01 +0000 Original-Received: (at 67709) by debbugs.gnu.org; 16 Dec 2023 11:41:00 +0000 Original-Received: from localhost ([127.0.0.1]:54063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rET2S-0000X0-8R for submit@debbugs.gnu.org; Sat, 16 Dec 2023 06:41:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rET2P-0000We-G5 for 67709@debbugs.gnu.org; Sat, 16 Dec 2023 06:40:58 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rET2I-0006QV-L2; Sat, 16 Dec 2023 06:40:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/u8FwSXqHu8elCcvWJRjNrCXEn9yFa7WIMw9oQtc5sA=; b=lFMRupVG+V0f WIVzEJ9e/p33mwzIaQnYFIiNjgJkBxqhCeXQEiLVGghdLSd/FPpikCPaK+Nv06EhpMEBjGhDBHZcu vgNV7sCPdh/v65AWQ8TVjIogPhT3MiGE40a3n/ilY2aUhlMhPg6LQI2S5N23BCHE3t3gWgrc6ekJW eRLkgm7Kapj00ha8lPLaS2WEPOwEDXFYX7pCZhsQ4XJ9Ro/NNUyPy/ihgqUS/mRBFWdNeoEaKCFJs R4GddzqsCtCaN+JaoSfXyTwSH9vVpIL6jxJ+8SRyFV6ISinxwuxh/jv3rN3KgT3PBFHavUCy5GCqk VWj08Jx3EvcUOOItcQSnBA==; In-Reply-To: (message from Jacob Leeming on Fri, 8 Dec 2023 13:44:14 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276316 Archived-At: > From: Jacob Leeming > Date: Fri, 8 Dec 2023 13:44:14 +0000 > > >From emacs -Q: > > Evaluate this elisp to set up treesitter for csharp: > > (setq treesit-language-source-alist '((c-sharp > "https://github.com/tree-sitter/tree-sitter-c-sharp" "master" "src")) > treesit-load-name-override-list '((c-sharp > "libtree-sitter-csharp" "tree_sitter_c_sharp")) > major-mode-remap-alist '((csharp-mode . csharp-ts-mode))) > > Insert the following text into a csharp-ts-mode buffer: > > void ExampleFunction( > int arg1, > int arg2, > int arg3, > int arg4, > int arg5 > ) > { > Console.WriteLine(arg1); > } > > Try to indent the parameters of the function with > indent-for-tab-command. Nothing will happen. > > This issue can be fixed with the following patch: > > > > diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el > index 53c52e6..8cc4e95 100644 > --- a/lisp/progmodes/csharp-mode.el > +++ b/lisp/progmodes/csharp-mode.el > @@ -704,7 +704,8 @@ csharp-ts-mode--indent-rules > ((parent-is "object_type") parent-bol csharp-ts-mode-indent-offset) > ((parent-is "enum_body") parent-bol csharp-ts-mode-indent-offset) > ((parent-is "arrow_function") parent-bol csharp-ts-mode-indent-offset) > - ((parent-is "parenthesized_expression") parent-bol > csharp-ts-mode-indent-offset)))) > + ((parent-is "parenthesized_expression") parent-bol > csharp-ts-mode-indent-offset) > + ((parent-is "parameter_list") parent-bol csharp-ts-mode-indent-offset)))) > > (defvar csharp-ts-mode--keywords > '("using" "namespace" "class" "if" "else" "throw" "new" "for" Theo, any comments? Should I install this? Thanks.