From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 37889523278: Add new `swap` macro and use it Date: Sat, 06 Jan 2024 15:59:50 +0200 Message-ID: <83v886sgtl.fsf@gnu.org> References: <170452579053.27998.16123231327386305897@vcs2.savannah.gnu.org> <20240106072311.28B8FC0034E@vcs2.savannah.gnu.org> <87plye9ahs.fsf@yahoo.com> <83o7dyua0d.fsf@gnu.org> <87le9297ei.fsf@yahoo.com> <87cyue92fx.fsf@yahoo.com> <877ckm8uzz.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29132"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 06 15:00:30 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rM7Dx-0007NY-MP for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jan 2024 15:00:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rM7DW-0002R1-7v; Sat, 06 Jan 2024 09:00:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rM7DU-0002QC-Dm for emacs-devel@gnu.org; Sat, 06 Jan 2024 09:00:00 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rM7DU-0007Rl-4u; Sat, 06 Jan 2024 09:00:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CA8xDS+06rHuT/1b+pjGwIeedaAB3xZ7LHtODDxTNOk=; b=qH0vXPeoKrI5 tGD31QqDlLsRgG/XWimB9CbYkITkYXxVwE06NcMbAlHYpgWxyuK+E58auQz03Abb6YYMoqtdiC8/G dFAt4e3WnxwKlzrg/SU59+pSsnokeh4N55tkSlt6SdpqWAt4BfETUfOufrtGGyteQEUzeza7wD+1V Udatk12CbcMC9xynmDAUE0AFOMhKnyROJq1aortUQ69C/jb8n5NOzrmtwfJ9NMgs6Bfq6RUxbzTtt ISSopm90kjdIFC6vMoCYgsubvFE2JV4xzX2k5MA2/9uFGvYxy5TDDqEgc2mSSfUf0ye34zd9osOWh ec9pMZCPCVSAVpNO813hNA==; In-Reply-To: <877ckm8uzz.fsf@yahoo.com> (message from Po Lu on Sat, 06 Jan 2024 21:13:52 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314627 Archived-At: > From: Po Lu > Cc: Eli Zaretskii , emacs-devel@gnu.org > Date: Sat, 06 Jan 2024 21:13:52 +0800 > > Stefan Kangas writes: > > > OK, I think I see where you are coming from. My interpretation of that > > discussion is a bit different. > > > > To my mind, that discussion was mainly about what people use in their > > day-to-day hacking on Emacs, because that's where the disruption happens > > when the build is broken even if it's only broken briefly. > > There's no reason to hesitate before reverting a minor change that > neither provides new features nor modifies internal details in a manner > beneficial to users of systems it doesn't affect. Please in the future only revert commits by others without discussion if they either completely break a build or are obviously wrong. Everything else should be discussed first. Did Stefan's change break some build? If so, which build became broken and why?