From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 37889523278: Add new `swap` macro and use it Date: Sun, 07 Jan 2024 16:37:51 +0200 Message-ID: <83v885qke8.fsf@gnu.org> References: <170452579053.27998.16123231327386305897@vcs2.savannah.gnu.org> <20240106072311.28B8FC0034E@vcs2.savannah.gnu.org> <87plye9ahs.fsf@yahoo.com> <83o7dyua0d.fsf@gnu.org> <87le9297ei.fsf@yahoo.com> <87cyue92fx.fsf@yahoo.com> <877ckm8uzz.fsf@yahoo.com> <83v886sgtl.fsf@gnu.org> <83plyescg9.fsf@gnu.org> <87wmsl7wh9.fsf@yahoo.com> <87sf397faq.fsf@yahoo.com> <87o7dx77mw.fsf@yahoo.com> <83wmslqsv6.fsf@gnu.org> <87frz9742p.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40569"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 07 15:38:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rMUIi-000AHo-3Y for ged-emacs-devel@m.gmane-mx.org; Sun, 07 Jan 2024 15:38:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMUHo-00067E-Hk; Sun, 07 Jan 2024 09:38:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMUHn-00066z-DF for emacs-devel@gnu.org; Sun, 07 Jan 2024 09:37:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMUHm-0002bo-3c; Sun, 07 Jan 2024 09:37:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wA5NKTo4hClUOnUULm+y1x05prWtVaVc0KG/nJr09Vo=; b=F64PnMlXVZAx CZPRK7B4FpDOUhxpod8Qj5JwbWAJIu9jU7RL4Z63HNyOUcs8KPg8CWwTgFXsMWBNT3xABAnwIjvRa 66K7HlOox2SzPmS3xYv/mJ4AvjE0eCDsVeNIofG/M7IS1Nli1S6+WDMd0XHKPBXGcSj90HleHXIGL OwovOWooFqrnDw2K8z4orDoVbpKc+gpDxlKZ6duhUhLMV4g/mmUeDwqpwPvkY9IsSJ0arAXbIzwSh 2wQh3GWyqLYqCoZV0ifFExvrZ0X1mXS213MZgWD8FIOKsIcBc5zcoUf0NoqgmUmjfEDbCuuPvUYNP 8sJ7un8ObNGtqPN/D1RMBQ==; In-Reply-To: <87frz9742p.fsf@yahoo.com> (message from Po Lu on Sun, 07 Jan 2024 19:53:02 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314686 Archived-At: > From: Po Lu > Cc: stefankangas@gmail.com, emacs-devel@gnu.org > Date: Sun, 07 Jan 2024 19:53:02 +0800 > > Eli Zaretskii writes: > > > Please raise these issues with the Gnulib folks, not here. Meanwhile, > > what's good enough for Gnulib should be good enough for us. > > Stefan's patch doesn't replicate any choices made by Gnulib besides the > test for __typeof__'s presence, so what Gnulib does is beside the point. > > The problem at hand is that we should not define macros which behave in > such drastically different manners across compilers subject to the > presence of __typeof__, much less macros whose erroneous invocations can > only be detected in a small portion of the configurations Emacs is built > in, and even then not without rigorous testing. I don't see how this disqualifies the patch. We have other macros and constructs that need to be used with care. > >> Never in my life have I heard the statements for swapping two variables > >> characterized as "insufficiently readable" > > > > With all due respect, if you don't want your own stylistic preferences > > to be questioned, please don't question those of others. Let's all > > respect the preferences of each other, okay? > > OK, but "swap" macros are likewise personal stylistic preferences, and > ones defective for significant and widely-recognized technical reasons > at that. And I ask you to respect Stefan's stylistic preferences here.