From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs,gmane.emacs.orgmode Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Fri, 12 Jan 2024 16:03:41 +0200 Message-ID: <83v87yir7m.fsf@gnu.org> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83cyyw4of7.fsf@gnu.org> <875y4ovct9.fsf@localhost> <875y04yq9s.fsf@localhost> <875y02y0da.fsf@localhost> <87frz6w2zt.fsf@localhost> <83cyu9nyea.fsf@gnu.org> <87sf35pcds.fsf@localhost> <83y1cxmgws.fsf@gnu.org> <87ttnjj2dp.fsf@localhost> <83bk9rlusw.fsf@gnu.org> <87h6jjj17y.fsf@localhost> <838r4vlt0n.fsf@gnu.org> <87bk9rivzo.fsf@localhost> <8334v3lltf.fsf@gnu.org> <87le8uhh9a.fsf@localhost> <83zfxaivfv.fsf@gnu.org> <87v87ypvyh.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38055"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65734@debbugs.gnu.org, manikulin@gmail.com, emacs-orgmode@gnu.org, monnier@iro.umontreal.ca, iota@whxvd.name To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 12 15:05:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rOIAX-0009gP-7g for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jan 2024 15:05:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOIA8-0000BH-7u; Fri, 12 Jan 2024 09:05:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOI9g-0008Gj-3I for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 09:05:06 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOI9f-000762-R5 for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 09:05:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rOI9d-0002mZ-Lz for bug-gnu-emacs@gnu.org; Fri, 12 Jan 2024 09:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jan 2024 14:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65734 X-GNU-PR-Package: emacs Original-Received: via spool by 65734-submit@debbugs.gnu.org id=B65734.170506824410618 (code B ref 65734); Fri, 12 Jan 2024 14:05:01 +0000 Original-Received: (at 65734) by debbugs.gnu.org; 12 Jan 2024 14:04:04 +0000 Original-Received: from localhost ([127.0.0.1]:35226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOI8h-0002lB-TW for submit@debbugs.gnu.org; Fri, 12 Jan 2024 09:04:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rOI8e-0002kY-I9 for 65734@debbugs.gnu.org; Fri, 12 Jan 2024 09:04:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOI8Z-0006lA-Sh; Fri, 12 Jan 2024 09:03:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2m1Et1jvfv6IEay8U8dwPNOaOafFIbEVXo8zRwPiYKk=; b=RTYjkghPuo7Z nbR3lfemzbO1Xg+sBeHD0eU/6UbIQsjze87uo8kQNOHQ/saU6HCM8IeQebaFo4xR74i/uHmMo1DLA ZhWpPXkIDTB/9ewQr7a+SXSOok9hEvCJQlMtKbbyjYZo5ZbUFlWTGkXf4xk/5fW77+Hcr2SWgKr17 vTKIM/oq9y0jZvWkQMT8FwCSvdERjvRdl/yGbC0Ce13nao3VlBfD+/vLoIWkt9hgvhocjrR0wMkia tlm+cr4vUig50q4NjXQES3nojP4se7IAmPlGfecg1+cuodDp6lHZGiXZomB27VPUUejxOZQqNA3SN L0LlUeCtbhdWIWV/cPhIvg==; In-Reply-To: <87v87ypvyh.fsf@localhost> (message from Ihor Radchenko on Fri, 12 Jan 2024 12:39:18 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278028 gmane.emacs.orgmode:159037 Archived-At: > From: Ihor Radchenko > Cc: monnier@iro.umontreal.ca, emacs-orgmode@gnu.org, 65734@debbugs.gnu.org, > manikulin@gmail.com, iota@whxvd.name > Date: Fri, 12 Jan 2024 12:39:18 +0000 > > Eli Zaretskii writes: > > >> I think that I see what you mean. What we can do to achieve this is > >> changing `kill-line-query-function' into abnormal hook > >> `kill-line-query-functions'. Then, `kill-line'/`kill-whole-line' will > >> use (run-hook-with-args-until-success 'kill-line-query-functions) to > >> decide whether to show a query. > >> > >> Does it make sense? > > > > It might, yes. But do we have to _replace_ the hook? cannot we have > > both? I.e. if the new one is defined, call it, otherwise call the old > > one. That would be more backward-compatible, I think. > > May you please elaborate what you mean by "old one"? kill-line-query-function From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id CGUjC01HoWX18QAAkFu2QA (envelope-from ) for ; Fri, 12 Jan 2024 15:06:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id kA4pBk1HoWU7UwAA62LTzQ (envelope-from ) for ; Fri, 12 Jan 2024 15:06:05 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=RTYjkghP; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705068365; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=2m1Et1jvfv6IEay8U8dwPNOaOafFIbEVXo8zRwPiYKk=; b=DRJ1331gaGC8jxOUjBXhzgG/S87c6rGcgELKwoPUhnb+RlJIDsxrx3sTu+qG0kBW2Anw9h sNXi4uR/N2MRqWdjlnrKdsH9nIIPbJgHXKIYqbfXt/84NGe/C6kS4MIf5kJm6v5sPiadRy ISI6lnQwCJg5ToeMF8aZmXs5k+Kgj3vO28xSNQZldyPa+dKWDvwkpc+cDmdQDCfxqYY4fu XBdTOxRi+koG0Kv1wCSuZWRRntr8FNgQ5cZ2b48+6IpZs9GFmLhbeP8gjxEZrFlYTjzv6p GJHuLRZfxRD7dpQ+tFJX2M+Bh4s/qzQf4x1ouO9Y9D+hdLS6+eVUKtFnZSn9OA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=RTYjkghP; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705068365; a=rsa-sha256; cv=none; b=Af/1hZ62fdrtMz3UlO6r64hSd6TCa9frEnM5XSsLK37S5079w0NYvYm+lbCi2UIBPzW9gX SsME1Ny6vsGBpLOi2mDn8yYV/tDKfFMgVCd4WItWKYo+vQMxyWTK2cZN2hZlV8nph/kssb C9hkAFAPAiTPMPhcyDCwQpLCJM0G7vY+iGs/I2+wwW6jVuIVAYiwIHhB8ClG/XYue1s6hZ Y/LhGBMr1MnDnUaALxi27grgy03accaMqiV5b91+DvZ0EeK4OdlmttLAIpKbUNOmPNdFqn 1l0sIaHWSpc8SlLyOqfz6p7DLY0Cs6x2PX9wH0bpe3oZa1/cZDZ7jB42OFiKFg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B65AB44F3C for ; Fri, 12 Jan 2024 15:06:04 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOI99-0007fa-2w; Fri, 12 Jan 2024 09:04:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOI8b-000745-HA for emacs-orgmode@gnu.org; Fri, 12 Jan 2024 09:04:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOI8Z-0006lA-Sh; Fri, 12 Jan 2024 09:03:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2m1Et1jvfv6IEay8U8dwPNOaOafFIbEVXo8zRwPiYKk=; b=RTYjkghPuo7Z nbR3lfemzbO1Xg+sBeHD0eU/6UbIQsjze87uo8kQNOHQ/saU6HCM8IeQebaFo4xR74i/uHmMo1DLA ZhWpPXkIDTB/9ewQr7a+SXSOok9hEvCJQlMtKbbyjYZo5ZbUFlWTGkXf4xk/5fW77+Hcr2SWgKr17 vTKIM/oq9y0jZvWkQMT8FwCSvdERjvRdl/yGbC0Ce13nao3VlBfD+/vLoIWkt9hgvhocjrR0wMkia tlm+cr4vUig50q4NjXQES3nojP4se7IAmPlGfecg1+cuodDp6lHZGiXZomB27VPUUejxOZQqNA3SN L0LlUeCtbhdWIWV/cPhIvg==; Date: Fri, 12 Jan 2024 16:03:41 +0200 Message-Id: <83v87yir7m.fsf@gnu.org> From: Eli Zaretskii To: Ihor Radchenko Cc: monnier@iro.umontreal.ca, emacs-orgmode@gnu.org, 65734@debbugs.gnu.org, manikulin@gmail.com, iota@whxvd.name In-Reply-To: <87v87ypvyh.fsf@localhost> (message from Ihor Radchenko on Fri, 12 Jan 2024 12:39:18 +0000) Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83cyyw4of7.fsf@gnu.org> <875y4ovct9.fsf@localhost> <875y04yq9s.fsf@localhost> <875y02y0da.fsf@localhost> <87frz6w2zt.fsf@localhost> <83cyu9nyea.fsf@gnu.org> <87sf35pcds.fsf@localhost> <83y1cxmgws.fsf@gnu.org> <87ttnjj2dp.fsf@localhost> <83bk9rlusw.fsf@gnu.org> <87h6jjj17y.fsf@localhost> <838r4vlt0n.fsf@gnu.org> <87bk9rivzo.fsf@localhost> <8334v3lltf.fsf@gnu.org> <87le8uhh9a.fsf@localhost> <83zfxaivfv.fsf@gnu.org> <87v87ypvyh.fsf@localhost> X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -8.86 X-Spam-Score: -8.86 X-Migadu-Queue-Id: B65AB44F3C X-TUID: oW66r94GnbsJ > From: Ihor Radchenko > Cc: monnier@iro.umontreal.ca, emacs-orgmode@gnu.org, 65734@debbugs.gnu.org, > manikulin@gmail.com, iota@whxvd.name > Date: Fri, 12 Jan 2024 12:39:18 +0000 > > Eli Zaretskii writes: > > >> I think that I see what you mean. What we can do to achieve this is > >> changing `kill-line-query-function' into abnormal hook > >> `kill-line-query-functions'. Then, `kill-line'/`kill-whole-line' will > >> use (run-hook-with-args-until-success 'kill-line-query-functions) to > >> decide whether to show a query. > >> > >> Does it make sense? > > > > It might, yes. But do we have to _replace_ the hook? cannot we have > > both? I.e. if the new one is defined, call it, otherwise call the old > > one. That would be more backward-compatible, I think. > > May you please elaborate what you mean by "old one"? kill-line-query-function