From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Willing to debug bug #3542 (23.0.94; File access via UNC path slow again under Windows) Date: Mon, 13 Jul 2009 23:13:20 +0300 Message-ID: <83tz1gqr33.fsf@gnu.org> References: <7dbe73ed0907051401o26903ca3t9a67060f3a3417ad@mail.gmail.com> <83fxda1pef.fsf@gnu.org> <7dbe73ed0907060038w53699f77ie742996955ae8118@mail.gmail.com> <838wj11sz4.fsf@gnu.org> <83my7fz09s.fsf@gnu.org> <7dbe73ed0907081347q12dfd1a2lbbff915c49362f75@mail.gmail.com> <4A55D68D.8050407@gnu.org> <7dbe73ed0907090453s3e125b4ar142b90a268b105e2@mail.gmail.com> <7DAFC004A33C486A9E29A59689E7F02E@us.oracle.com> <4A5619F5.8010008@gnu.org> <8363e1zoak.fsf@gnu.org> <83hbxjrmue.fsf@gnu.org> <83ws6cqudb.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1247516019 19561 80.91.229.12 (13 Jul 2009 20:13:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 13 Jul 2009 20:13:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 13 22:13:32 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MQRtz-0006Es-2U for ged-emacs-devel@m.gmane.org; Mon, 13 Jul 2009 22:13:31 +0200 Original-Received: from localhost ([127.0.0.1]:36012 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MQRty-00044e-9b for ged-emacs-devel@m.gmane.org; Mon, 13 Jul 2009 16:13:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MQRtt-00044N-QN for emacs-devel@gnu.org; Mon, 13 Jul 2009 16:13:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MQRts-000443-Op for emacs-devel@gnu.org; Mon, 13 Jul 2009 16:13:25 -0400 Original-Received: from [199.232.76.173] (port=37303 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MQRts-000440-L5 for emacs-devel@gnu.org; Mon, 13 Jul 2009 16:13:24 -0400 Original-Received: from mtaout3.012.net.il ([84.95.2.7]:8665) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MQRts-0000EA-3P for emacs-devel@gnu.org; Mon, 13 Jul 2009 16:13:24 -0400 Original-Received: from conversion-daemon.i_mtaout3.012.net.il by i_mtaout3.012.net.il (HyperSendmail v2004.12) id <0KMQ00K00LGWG200@i_mtaout3.012.net.il> for emacs-devel@gnu.org; Mon, 13 Jul 2009 23:13:22 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.126.66.189]) by i_mtaout3.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KMQ00EFQLI9N9E0@i_mtaout3.012.net.il>; Mon, 13 Jul 2009 23:13:22 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:112426 Archived-At: > From: Andreas Schwab > Cc: emacs-devel@gnu.org > Date: Mon, 13 Jul 2009 21:39:20 +0200 > > See allocate_string_data. Aha. But it sounds like it's not just me who is confused. Here's just two examples: From doc.c: strp = SDATA (string); while (strp < SDATA (string) + SBYTES (string)) (why not "while *strp"?) From fileio.c: nm = (unsigned char *) alloca (SBYTES (filename) + 1); bcopy (SDATA (filename), nm, SBYTES (filename) + 1); (why +1? it potentially accesses memory beyond end of `filename's contents) Anyway, thanks. I will fix the code I committed.