From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#7308: [patch] locate under windoze Date: Sun, 14 Nov 2010 05:59:17 +0200 Message-ID: <83tyjkd08a.fsf@gnu.org> References: <87hbg3piit.fsf@pusto.de> <87d3qpytrx.fsf@pusto.de> <87wroiuvzy.fsf@pusto.de> <87mxpdkq68.fsf@stupidchicken.com> <8339r4exco.fsf@gnu.org> <87oc9sq2fv.fsf@pusto.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1289708070 13019 80.91.229.12 (14 Nov 2010 04:14:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 14 Nov 2010 04:14:30 +0000 (UTC) Cc: 7308@debbugs.gnu.org, cyd@stupidchicken.com To: Eduard Wiebe Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 14 05:14:22 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PHTyv-0003u8-6D for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Nov 2010 05:14:21 +0100 Original-Received: from localhost ([127.0.0.1]:57063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHTyt-0005aV-N8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Nov 2010 23:14:19 -0500 Original-Received: from [140.186.70.92] (port=58971 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PHTym-0005Yq-0E for bug-gnu-emacs@gnu.org; Sat, 13 Nov 2010 23:14:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PHTyf-0001H9-V5 for bug-gnu-emacs@gnu.org; Sat, 13 Nov 2010 23:14:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PHTyf-0001H4-SH for bug-gnu-emacs@gnu.org; Sat, 13 Nov 2010 23:14:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PHTgE-0000v3-94; Sat, 13 Nov 2010 22:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Nov 2010 03:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7308 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 7308-submit@debbugs.gnu.org id=B7308.12897068633527 (code B ref 7308); Sun, 14 Nov 2010 03:55:02 +0000 Original-Received: (at 7308) by debbugs.gnu.org; 14 Nov 2010 03:54:23 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PHTfa-0000uq-UN for submit@debbugs.gnu.org; Sat, 13 Nov 2010 22:54:23 -0500 Original-Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PHTfX-0000ul-Ra for 7308@debbugs.gnu.org; Sat, 13 Nov 2010 22:54:21 -0500 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LBU00B00WCJON00@a-mtaout21.012.net.il> for 7308@debbugs.gnu.org; Sun, 14 Nov 2010 05:59:11 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.126.249.126]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LBU00BYGWEMKH50@a-mtaout21.012.net.il>; Sun, 14 Nov 2010 05:59:11 +0200 (IST) In-reply-to: <87oc9sq2fv.fsf@pusto.de> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 13 Nov 2010 22:55:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41605 Archived-At: > From: Eduard Wiebe > Cc: Chong Yidong , 7308@debbugs.gnu.org > Date: Sat, 13 Nov 2010 23:33:08 +0100 > > > I'm okay with the main change, but I don't understand the reason (or > > need) for this hunk: > > > > @@ -473,9 +483,9 @@ do not work in subdirectories. > > (make-local-variable 'directory-listing-before-filename-regexp) > > ;; This should support both Unix and Windoze style names > > (setq directory-listing-before-filename-regexp > > - (concat "^." > > + (concat "^.\\(" > > (make-string (1- locate-filename-indentation) ?\s) > > - "\\(/\\|[A-Za-z]:\\)\\|" > ^^^^^^^^^^^^^^^^^^^^ > > > + "\\)\\|" > > (default-value 'directory-listing-before-filename-regexp))) > > (make-local-variable 'dired-actual-switches) > > (setq dired-actual-switches "") > > This hunk is essential. The new value of the regexp avoids the > truncation of the drive letter from absolute path of the selected file. > > Btw. Under GNU/Linux this change leads to correct position of cursor in > *Locate* buffer, too. Sorry, I still don't understand: what truncation? what incorrect position? Please explain more. > PS: I tested my patch under GNU/Linux with GNU locate und MS-Windows > with everything-Tool for a while and it works fine. I never doubted that you tested the change. I just want to understand it.