From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: bookkeeping to prepare for a 64-bit EMACS_INT on 32-bit hosts
Date: Sat, 30 Apr 2011 10:30:11 +0300 [thread overview]
Message-ID: <83tydg5h8c.fsf@gnu.org> (raw)
In-Reply-To: <4DBBB23A.6050702@cs.ucla.edu>
> Date: Fri, 29 Apr 2011 23:54:50 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: emacs-devel@gnu.org
>
> On 04/29/11 02:06, Paul Eggert wrote:
> > I will look into extending that patch, so that it also works with
> > __int64.
>
> Here's one way to do that. Add this to nt/config.nt,
> after the BITS_PER_LONG definition:
>
> #if (defined __MINGW32__ \
> || 1400 <= _MSC_VER || (1310 <= _MSC_VER && defined _MSC_EXTENSIONS))
> /* C99-style long long and "%lld" both work, so use them. */
> # define BITS_PER_LONG_LONG 64
> #elif 1200 <= _MSC_VER
> /* Use pre-C99-style 64-bit integers. */
> # define EMACS_INT __int64
> # define BITS_PER_EMACS_INT 64
> # define pI "I64"
> #endif
Thanks!
> I inferred the above by looking at random stuff
> off the net, and haven't actually tested it; quite possibly
> it's not exactly right for Emacs but something like this should work.
I think it is correct, except for one minor gotcha: _MSC_EXTENSIONS do
NOT enable a `long long' data type in versions of MSVC before 1400.
_MSC_EXTENSIONS enable the use of __int64 in all versions of the MS
compiler. Also, _MSC_EXTENSIONS is on by default, so there's no need
to test for it explicitly. According to my reading of the MS
documentation, the `long long' data type is supported by MSVC only
starting from version 1400; before that, we should use __int64.
So I would change the above to say
#if (defined __MINGW32__ || 1400 <= _MSC_VER)
/* C99-style long long and "%lld" both work, so use them. */
# define BITS_PER_LONG_LONG 64
#elif 1200 <= _MSC_VER
/* Use pre-C99-style 64-bit integers. */
# define EMACS_INT __int64
# define BITS_PER_EMACS_INT 64
# define pI "I64"
#endif
> Also, I plan to simplify the rats-nest of EMACS_INT ifdefs in lisp.h
> to the following. This should make this stuff easier to follow.
That'd be fine, thanks.
next prev parent reply other threads:[~2011-04-30 7:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-29 8:08 bookkeeping to prepare for a 64-bit EMACS_INT on 32-bit hosts Paul Eggert
2011-04-29 8:49 ` Eli Zaretskii
2011-04-29 9:06 ` Paul Eggert
2011-04-29 9:17 ` Eli Zaretskii
2011-04-29 16:04 ` Stefan Monnier
2011-04-29 17:10 ` Eli Zaretskii
2011-04-29 17:32 ` Lars Magne Ingebrigtsen
2011-04-29 17:45 ` Paul Eggert
2011-04-29 18:50 ` David De La Harpe Golden
2011-04-30 5:00 ` Stephen J. Turnbull
2011-04-30 1:37 ` Paul Eggert
2011-05-02 14:46 ` Stefan Monnier
2011-05-02 16:09 ` Paul Eggert
2011-05-02 18:12 ` Stefan Monnier
2011-05-02 19:23 ` Paul Eggert
2011-05-02 19:49 ` Stefan Monnier
2011-04-30 6:54 ` Paul Eggert
2011-04-30 7:30 ` Eli Zaretskii [this message]
2011-04-29 8:56 ` support " Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83tydg5h8c.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.