From: Eli Zaretskii <eliz@gnu.org>
To: Fabrice Popineau <fabrice.popineau@supelec.fr>
Cc: ajmr@ilovetortilladepatatas.com, emacs-devel@gnu.org
Subject: Re: Windows 64 port
Date: Mon, 20 Feb 2012 22:47:23 +0200 [thread overview]
Message-ID: <83ty2ltep0.fsf@gnu.org> (raw)
In-Reply-To: <CAFgFV9O1VfEiDLQpbZ23xJyyX8EZb42DGGVCSakb9cCCRr59nw@mail.gmail.com>
> From: Fabrice Popineau <fabrice.popineau@supelec.fr>
> Date: Sun, 19 Feb 2012 23:05:52 +0100
> Cc: AJMR <ajmr@ilovetortilladepatatas.com>, emacs-devel@gnu.org
>
> Here is my Windows 64 bits patch. It is quite crude and only attempts to
> make it possible to compile a 64bits emacs with the MS Sdk.
I have a few questions about the patch (below).
> the heap allocation scheme should probably be reworked
Can you tell which parts of the current scheme need to be reworked,
and why do you think so?
> === modified file 'lib/strftime.c'
> --- lib/strftime.c 2011-03-31 04:24:03 +0000
> +++ lib/strftime.c 2011-12-05 13:09:35 +0000
> @@ -36,9 +36,13 @@
> #include <ctype.h>
> #include <time.h>
>
> +#ifdef _MSC_VER
> +#define tzname _tzname
> +#else
> #if HAVE_TZNAME && !HAVE_DECL_TZNAME
> extern char *tzname[];
> #endif
> +#endif
This seems to be unrelated to 64-bit hosts. Why is it needed, when
s/ms-w32.h has the same #define (which your patch #ifdef's away)?
What is the issue here?
> === modified file 'src/editfns.c'
> --- src/editfns.c 2012-01-19 07:21:25 +0000
> +++ src/editfns.c 2012-02-05 20:06:34 +0000
> @@ -82,6 +82,8 @@
>
> #ifdef WINDOWSNT
> extern Lisp_Object w32_get_internal_run_time (void);
> +
> +extern struct tm *localtime (const time_t *t);
> #endif
Why is this needed? It seems also unrelated to 64-bit Windows.
> -internal_lisp_condition_case (volatile Lisp_Object var, Lisp_Object bodyform,
> +internal_lisp_condition_case (/* volatile */ Lisp_Object var, Lisp_Object bodyform,
Does MSVC have problems with the `volatile' qualifier?
> --- src/frame.c 2012-01-19 07:21:25 +0000
> +++ src/frame.c 2012-02-05 20:06:34 +0000
> @@ -812,6 +812,7 @@
> #ifdef HAVE_WINDOW_SYSTEM
> if (track && FRAME_WINDOW_P (XFRAME (frame)))
> {
> + extern Lisp_Object x_get_focus_frame(struct frame *);
This should go into w32term.h (it is already in xterm.h and nsterm.h).
> --- src/m/amdx86-64.h 2012-01-19 07:21:25 +0000
> +++ src/m/amdx86-64.h 2012-02-05 20:06:34 +0000
> @@ -17,7 +17,8 @@
> You should have received a copy of the GNU General Public License
> along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>. */
>
> -#define BITS_PER_LONG 64
> +#define BITS_PER_LONG 32
Here Windows and Posix systems differ, so it's wrong to do this
unconditionally. Does the 64-bit Windows define _LLP64 or some such
somewhere on its headers? If so, perhaps we could condition the above
on that macro, vs _LP64 on Posix hosts.
> /* Define the type to use. */
> -#define EMACS_INT long
> -#define pI "l"
> -#define EMACS_UINT unsigned long
> +#define EMACS_INT __int64
> +#define EMACS_UINT unsigned __int64
> +#define pI "ll"
> +#define VIRT_ADDR_VARIES
> +#define DATA_START get_data_start ()
Likewise here.
Thanks.
next prev parent reply other threads:[~2012-02-20 20:47 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 20:18 Windows 64 port AJMR
2012-02-19 21:26 ` Eli Zaretskii
2012-02-19 22:05 ` Fabrice Popineau
2012-02-20 3:53 ` Eli Zaretskii
2012-02-20 17:48 ` Paul Eggert
2012-02-20 19:20 ` Fabrice Popineau
2012-02-20 20:43 ` Paul Eggert
2012-02-20 20:58 ` Eli Zaretskii
2012-02-20 23:11 ` Fabrice Popineau
2012-02-20 23:46 ` Paul Eggert
2012-02-21 13:22 ` Stefan Monnier
2012-02-21 18:26 ` Paul Eggert
2012-02-22 10:39 ` Richard Stallman
2012-02-22 16:27 ` Eli Zaretskii
2012-02-23 18:44 ` Richard Stallman
2012-02-23 19:16 ` Aurélien
2012-02-23 19:50 ` Lennart Borgman
2012-02-23 20:48 ` Fabrice Popineau
2012-02-24 5:52 ` Aurélien
2012-02-28 21:00 ` Fabrice Popineau
2012-02-28 22:09 ` Paul Eggert
2012-02-28 22:39 ` Fabrice Popineau
2012-02-29 18:08 ` Eli Zaretskii
2012-02-29 22:08 ` Paul Eggert
2012-02-29 18:04 ` Eli Zaretskii
2012-02-29 19:43 ` Paul Eggert
2012-02-29 21:24 ` Eli Zaretskii
2012-03-01 3:34 ` Paul Eggert
2012-03-01 4:03 ` Eli Zaretskii
2012-03-01 6:28 ` Paul Eggert
2012-03-01 7:04 ` Fabrice Popineau
2012-03-22 17:31 ` Fabrice Popineau
2012-03-23 18:26 ` Paul Eggert
2012-03-24 9:27 ` Fabrice Popineau
2012-03-22 17:39 ` Fabrice Popineau
2012-03-22 18:02 ` Andreas Schwab
2012-03-22 18:34 ` Fabrice Popineau
2012-03-22 22:46 ` Andreas Schwab
2012-03-22 23:06 ` Fabrice Popineau
2012-03-22 23:38 ` Andreas Schwab
2012-03-23 8:12 ` Eli Zaretskii
2012-03-23 9:45 ` Andreas Schwab
2012-03-23 10:27 ` Fabrice Popineau
2012-03-23 10:42 ` Andreas Schwab
2012-03-23 12:21 ` Eli Zaretskii
2012-03-23 10:11 ` Fabrice Popineau
2012-03-23 18:13 ` Paul Eggert
2012-02-20 20:47 ` Eli Zaretskii [this message]
2012-02-26 20:17 ` AJMR
2012-02-26 21:25 ` Eli Zaretskii
2012-02-27 17:37 ` AJMR
2012-02-28 21:32 ` Fabrice Popineau
2012-03-01 3:23 ` Paul Eggert
2012-03-01 7:24 ` Fabrice Popineau
2012-03-01 8:58 ` Paul Eggert
2012-03-01 17:45 ` Eli Zaretskii
2012-03-01 20:05 ` Fabrice Popineau
2012-03-02 9:22 ` Eli Zaretskii
2012-03-02 20:35 ` Paul Eggert
2012-03-02 21:32 ` Fabrice Popineau
2012-03-02 22:06 ` Eli Zaretskii
2012-03-03 5:42 ` Paul Eggert
2012-03-03 7:18 ` Eli Zaretskii
2012-03-04 21:48 ` Paul Eggert
2012-03-03 7:58 ` Eli Zaretskii
2012-03-10 13:43 ` Eli Zaretskii
2012-03-22 17:15 ` Fabrice Popineau
2012-03-22 17:22 ` Fabrice Popineau
2012-03-22 18:29 ` Fabrice Popineau
2012-03-22 20:53 ` Stefan Monnier
2012-03-27 12:47 ` Fabrice Popineau
2012-03-27 16:08 ` Paul Eggert
2012-02-20 9:41 ` Richard Stallman
2012-02-20 10:28 ` Dani Moncayo
2012-02-21 12:10 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ty2ltep0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=ajmr@ilovetortilladepatatas.com \
--cc=emacs-devel@gnu.org \
--cc=fabrice.popineau@supelec.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.