From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11935: XINT etc. should be functions Date: Tue, 17 Jul 2012 06:04:14 +0300 Message-ID: <83txx79jgx.fsf@gnu.org> References: <500039B7.8050106@cs.ucla.edu> <5002C895.4080400@cs.ucla.edu> <500499C7.20902@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: dough.gmane.org 1342494315 17180 80.91.229.3 (17 Jul 2012 03:05:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 17 Jul 2012 03:05:15 +0000 (UTC) Cc: 11935@debbugs.gnu.org, rms@gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 17 05:05:14 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sqy60-0002ap-M1 for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jul 2012 05:05:08 +0200 Original-Received: from localhost ([::1]:53599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sqy5z-000364-Gd for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jul 2012 23:05:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sqy5x-00034y-5t for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2012 23:05:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sqy5w-0008FB-5q for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2012 23:05:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sqy5w-0008Et-2R for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2012 23:05:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SqyBh-0005ce-Iy for bug-gnu-emacs@gnu.org; Mon, 16 Jul 2012 23:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jul 2012 03:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11935-submit@debbugs.gnu.org id=B11935.134249461021550 (code B ref 11935); Tue, 17 Jul 2012 03:11:01 +0000 Original-Received: (at 11935) by debbugs.gnu.org; 17 Jul 2012 03:10:10 +0000 Original-Received: from localhost ([127.0.0.1]:44947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqyAr-0005bX-Qy for submit@debbugs.gnu.org; Mon, 16 Jul 2012 23:10:10 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:33540) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqyAo-0005bJ-SW for 11935@debbugs.gnu.org; Mon, 16 Jul 2012 23:10:07 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0M7A00D00B32DQ00@a-mtaout23.012.net.il> for 11935@debbugs.gnu.org; Tue, 17 Jul 2012 06:04:06 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.210.75]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0M7A00D4YB6UCY20@a-mtaout23.012.net.il>; Tue, 17 Jul 2012 06:04:06 +0300 (IDT) In-reply-to: <500499C7.20902@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:62015 Archived-At: > Date: Mon, 16 Jul 2012 15:46:31 -0700 > From: Paul Eggert > Cc: 11935@debbugs.gnu.org > > +#if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 2) > +# define ALWAYS_INLINE __attribute__ ((__always_inline__)) > +#else > +# define ALWAYS_INLINE > +#endif > + > +/* When compiling via GCC without optimization, and without -DINLINING=0, > + always inline functions marked 'inline'. This typically improves CPU > + performance when debugging. With optimization, trust the compiler > + to inline as appropriate. */ > +#ifndef INLINING > +# define INLINING 1 > +#endif > +#if (defined __NO_INLINE__ \ > + && ! defined __OPTIMIZE__ && ! defined __OPTIMIZE_SIZE__ \ > + && INLINING && !defined inline) > +# define inline ALWAYS_INLINE > +#endif > + Wouldn't this inline all the functions declared 'inline'? If so, that's going too far, IMO. I think we need a facility for doing this only with a few functions that affect performance.