From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 12387@debbugs.gnu.org, emacs18@gmail.com
Subject: bug#12387: 24.2.50; File column printed by list-buffers is bad if done in dired-mode
Date: Thu, 13 Sep 2012 20:07:38 +0300 [thread overview]
Message-ID: <83txv1vokl.fsf@gnu.org> (raw)
In-Reply-To: <5051A943.9030200@gmx.at>
> Date: Thu, 13 Sep 2012 11:37:07 +0200
> From: martin rudalics <rudalics@gmx.at>
> Cc: 12387@debbugs.gnu.org, emacs18@gmail.com
>
> Does the patch below fix it?
>
> martin
>
> === modified file 'src/xdisp.c'
> --- src/xdisp.c 2012-09-12 00:14:50 +0000
> +++ src/xdisp.c 2012-09-13 09:31:34 +0000
> @@ -21039,8 +21039,7 @@
> : EQ (face, Qtool_bar) ? TOOL_BAR_FACE_ID
> : DEFAULT_FACE_ID;
>
> - if (XBUFFER (buffer) != current_buffer)
> - old_buffer = current_buffer;
> + old_buffer = current_buffer;
>
> /* Save things including mode_line_proptrans_alist,
> and set that to nil so that we don't alter the outer value. */
> @@ -21051,8 +21050,7 @@
> mode_line_proptrans_alist = Qnil;
>
> Fselect_window (window, Qt);
> - if (old_buffer)
> - set_buffer_internal_1 (XBUFFER (buffer));
> + set_buffer_internal_1 (XBUFFER (buffer));
>
> init_iterator (&it, w, -1, -1, NULL, face_id);
IMO, that's exactly what needs to be done. The attempts to avoid
calling set_buffer_internal_1 are a classical case of premature
optimization, since that function already knows how to avoid changing
to the same buffer.
next prev parent reply other threads:[~2012-09-13 17:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 15:50 bug#12387: 24.2.50; File column printed by list-buffers is bad if done in dired-mode emacs18
2012-09-13 7:52 ` Glenn Morris
2012-09-13 9:37 ` martin rudalics
2012-09-13 17:07 ` Eli Zaretskii [this message]
2012-09-14 9:00 ` martin rudalics
2012-09-14 17:08 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83txv1vokl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=12387@debbugs.gnu.org \
--cc=emacs18@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.