From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13007: 24.3.50; emacs_backtrace.txt Date: Fri, 30 Nov 2012 18:59:47 +0200 Message-ID: <83txs7t4ak.fsf@gnu.org> References: <9FE4F131C0C94FC79470495A8506A387@us.oracle.com> <83k3t7xemd.fsf@gnu.org> <50B4EF28.6040905@yandex.ru> <834nkbx7if.fsf@gnu.org> <50B5BB01.2070304@yandex.ru> <50B63309.1070404@yandex.ru> <838v9lwqvn.fsf@gnu.org> <50B6FE89.20304@yandex.ru> <83txs8uzkc.fsf@gnu.org> <50B79A19.2050707@yandex.ru> <83a9tzv2m0.fsf@gnu.org> <50B8D5E1.7090005@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1354294869 8522 80.91.229.3 (30 Nov 2012 17:01:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 30 Nov 2012 17:01:09 +0000 (UTC) Cc: 13007@debbugs.gnu.org, lekktu@gmail.com To: Dmitry Antipov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 30 18:01:21 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TeTxo-0004MJ-VX for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Nov 2012 18:01:21 +0100 Original-Received: from localhost ([::1]:42574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeTxd-0000Oo-AI for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Nov 2012 12:01:09 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeTxU-0008UA-Lm for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2012 12:01:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TeTxQ-0005sU-Af for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2012 12:01:00 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TeTxQ-0005sM-66 for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2012 12:00:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TeTzR-0000ht-RO for bug-gnu-emacs@gnu.org; Fri, 30 Nov 2012 12:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Nov 2012 17:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13007 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13007-submit@debbugs.gnu.org id=B13007.13542949332610 (code B ref 13007); Fri, 30 Nov 2012 17:03:01 +0000 Original-Received: (at 13007) by debbugs.gnu.org; 30 Nov 2012 17:02:13 +0000 Original-Received: from localhost ([127.0.0.1]:47217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeTye-0000g1-Ei for submit@debbugs.gnu.org; Fri, 30 Nov 2012 12:02:12 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:56943) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeTyb-0000fn-EV for 13007@debbugs.gnu.org; Fri, 30 Nov 2012 12:02:10 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MEB00K0089H7R00@a-mtaout23.012.net.il> for 13007@debbugs.gnu.org; Fri, 30 Nov 2012 19:00:01 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MEB00J128K0YQC0@a-mtaout23.012.net.il>; Fri, 30 Nov 2012 19:00:01 +0200 (IST) In-reply-to: <50B8D5E1.7090005@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67667 Archived-At: > Date: Fri, 30 Nov 2012 19:50:57 +0400 > From: Dmitry Antipov > CC: 13007@debbugs.gnu.org, lekktu@gmail.com, drew.adams@oracle.com > > There is one more similar thing: if we can enter redisplay_internal > with different current_buffer and selected window's buffer, we can > confuse reconsider_clip_changes, which comment explicitly assumes > that W->buffer and B are the same buffer. I don't see that. That function checks if the buffer is the same as the one recorded in window's matrix. > What if we just delay the real redisplay action until current_buffer > and selected window's buffer becomes synchronized, assuming that it > happens in the very near future (when someone finally update current_buffer > with selected window's buffer and then attract redisplay attention with > ++windows_or_buffers_changed or similar)? I don't think you can do that, since sometimes a non-selected window needs to be redisplayed. > IIUC pseudo-windows are always non-leaf; so, selected_window can't be > a pseudo-window, and pseudo-window can't be passed to redisplay_window. Are the menu-bar and tool-bar "windows" non-leaf? > static void > reconsider_clip_changes (struct window *w, struct buffer *b) > { > + eassert (XBUFFER (w->buffer) == b); > + How is this different from this: > if (b->clip_changed > && !NILP (w->window_end_valid) > && w->current_matrix->buffer == b ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > + if (XBUFFER (w->buffer) != current_buffer) > + /* Out of sync, do nothing. */ > + goto end_of_redisplay; I'm nervous about this, to tell the truth. redisplay_internal never dependent on current_buffer.