* bug#13872: 24.3-rc1; TERM_HEADER multiply defined during 'configure'
@ 2013-03-05 5:26 Paul Eggert
2013-03-05 8:28 ` Glenn Morris
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Paul Eggert @ 2013-03-05 5:26 UTC (permalink / raw)
To: 13872
Building Emacs 24.3-rc1 on Fedora 17 x86-64 generates a config.log with
lots of these diagnostics:
conftest.c:242:0: warning: "TERM_HEADER" redefined [enabled by default]
conftest.c:71:0: note: this is the location of the previous definition
The problem is that TERM_HEADER is put into conftest.c twice, with
disagreeing definitions:
#define TERM_HEADER "xterm.h"
...
#define TERM_HEADER "gtkutil.h"
On this platform it happens to work, but I worry that on other
platforms the C compiler will reject any such test program (as it is
entitled to do), which will cause later configuration decisions to
go wrong.
Here's a fix. This looks pretty safe.
=== modified file 'ChangeLog'
--- ChangeLog 2013-03-05 03:43:52 +0000
+++ ChangeLog 2013-03-05 05:21:41 +0000
@@ -1,3 +1,8 @@
+2013-03-05 Paul Eggert <eggert@cs.ucla.edu>
+
+ * configure.ac (TERM_HEADER): Remove duplicate definition
+ that can mess up 'configure' runs.
+
2013-03-05 Glenn Morris <rgm@gnu.org>
* Makefile.in (install-man): Ignore gzip exit status.
=== modified file 'configure.ac'
--- configure.ac 2013-03-05 03:53:34 +0000
+++ configure.ac 2013-03-05 04:50:24 +0000
@@ -1646,11 +1646,6 @@
;;
esac
-if test -n "${term_header}"; then
- AC_DEFINE_UNQUOTED(TERM_HEADER, "${term_header}",
- [Define to the header for the built-in window system.])
-fi
-
if test "$window_system" = none && test "X$with_x" != "Xno"; then
AC_CHECK_PROG(HAVE_XSERVER, X, true, false)
if test "$HAVE_XSERVER" = true ||
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#13872: 24.3-rc1; TERM_HEADER multiply defined during 'configure'
2013-03-05 5:26 bug#13872: 24.3-rc1; TERM_HEADER multiply defined during 'configure' Paul Eggert
@ 2013-03-05 8:28 ` Glenn Morris
2013-03-05 17:42 ` Eli Zaretskii
2013-03-05 13:40 ` Ken Brown
2013-03-05 17:20 ` Glenn Morris
2 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2013-03-05 8:28 UTC (permalink / raw)
To: 13872
How marvellous to hear about this now.
Sigh.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#13872: 24.3-rc1; TERM_HEADER multiply defined during 'configure'
2013-03-05 8:28 ` Glenn Morris
@ 2013-03-05 17:42 ` Eli Zaretskii
0 siblings, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2013-03-05 17:42 UTC (permalink / raw)
To: Glenn Morris; +Cc: 13872
> From: Glenn Morris <rgm@gnu.org>
> Date: Tue, 05 Mar 2013 03:28:59 -0500
>
>
> How marvellous to hear about this now.
> Sigh.
There's nothing you or anyone else could do about that. First Law of
Release Management states that no matter how long you delay the
release trying to make it bug-free, a critical bug will be reported
within hours of the release announcement.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#13872: 24.3-rc1; TERM_HEADER multiply defined during 'configure'
2013-03-05 5:26 bug#13872: 24.3-rc1; TERM_HEADER multiply defined during 'configure' Paul Eggert
2013-03-05 8:28 ` Glenn Morris
@ 2013-03-05 13:40 ` Ken Brown
2013-03-05 14:56 ` Paul Eggert
2013-03-05 17:20 ` Glenn Morris
2 siblings, 1 reply; 7+ messages in thread
From: Ken Brown @ 2013-03-05 13:40 UTC (permalink / raw)
To: Paul Eggert; +Cc: 13872
On 3/5/2013 12:26 AM, Paul Eggert wrote:
> Here's a fix. This looks pretty safe.
Are you sure there are no tests between the two definitions of
TERM_HEADER for which the latter should be defined?
I'm copying Daniel Colascione, since he's the one who introduced
TERM_HEADER.
Ken
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#13872: 24.3-rc1; TERM_HEADER multiply defined during 'configure'
2013-03-05 13:40 ` Ken Brown
@ 2013-03-05 14:56 ` Paul Eggert
0 siblings, 0 replies; 7+ messages in thread
From: Paul Eggert @ 2013-03-05 14:56 UTC (permalink / raw)
To: Ken Brown; +Cc: 13872
On 03/05/2013 05:40 AM, Ken Brown wrote:
> Are you sure there are no tests between the two definitions of TERM_HEADER
> for which the latter should be defined?
Yes, because no test uses TERM_HEADER:
$ grep TERM_HEADER configure
#define TERM_HEADER "${term_header}"
#define TERM_HEADER "${term_header}"
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#13872: 24.3-rc1; TERM_HEADER multiply defined during 'configure'
2013-03-05 5:26 bug#13872: 24.3-rc1; TERM_HEADER multiply defined during 'configure' Paul Eggert
2013-03-05 8:28 ` Glenn Morris
2013-03-05 13:40 ` Ken Brown
@ 2013-03-05 17:20 ` Glenn Morris
2013-03-05 17:26 ` Paul Eggert
2 siblings, 1 reply; 7+ messages in thread
From: Glenn Morris @ 2013-03-05 17:20 UTC (permalink / raw)
To: Paul Eggert; +Cc: 13872
OK, please apply to emacs-24.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-03-05 17:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-05 5:26 bug#13872: 24.3-rc1; TERM_HEADER multiply defined during 'configure' Paul Eggert
2013-03-05 8:28 ` Glenn Morris
2013-03-05 17:42 ` Eli Zaretskii
2013-03-05 13:40 ` Ken Brown
2013-03-05 14:56 ` Paul Eggert
2013-03-05 17:20 ` Glenn Morris
2013-03-05 17:26 ` Paul Eggert
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.