From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Colascione <dancol@dancol.org>
Cc: 13907@debbugs.gnu.org
Subject: bug#13907: 24.3.50; cygw32 build mishandles drag-n-dropped file with non-ASCII characters in name
Date: Fri, 08 Mar 2013 22:53:04 +0200 [thread overview]
Message-ID: <83txoly5ov.fsf@gnu.org> (raw)
In-Reply-To: <83vc91y6m4.fsf@gnu.org>
> Date: Fri, 08 Mar 2013 22:33:07 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 13907@debbugs.gnu.org
>
> And one more question: what is the value of file-name _before_ it is
> passed to cygwin-convert-file-name-from-windows? Does it perhaps
> already have the U-umlaut replaced by a blank?
I think the problem is on the C level, not on the Lisp level. Take a
look at w32term.c:construct_drag_n_drop -- it uses ANSI version of
DragQueryFile to get the file name, then decodes it by DECODE_FILE.
But DECODE_FILE uses UTF-8 in the cygw32 build, so this is
inappropriate for decoding file names that come from Windows APIs.
Instead, in the cygw32 build, construct_drag_n_drop should use
DragQueryFileW and convert the file name to the internal Emacs
representation using from_unicode.
next prev parent reply other threads:[~2013-03-08 20:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 17:18 bug#13907: 24.3.50; cygw32 build mishandles drag-n-dropped file with non-ASCII characters in name Ken Brown
2013-03-08 19:42 ` Eli Zaretskii
2013-03-08 20:06 ` Eli Zaretskii
2013-03-08 20:33 ` Eli Zaretskii
2013-03-08 20:53 ` Eli Zaretskii [this message]
2013-03-08 21:03 ` Ken Brown
2013-03-09 8:09 ` Eli Zaretskii
2013-03-08 21:25 ` Daniel Colascione
2013-03-09 3:03 ` Daniel Colascione
2013-03-09 3:03 ` Daniel Colascione
2013-03-09 8:32 ` Eli Zaretskii
2013-03-09 8:37 ` Daniel Colascione
2013-03-09 8:51 ` Eli Zaretskii
2013-03-09 8:37 ` Daniel Colascione
2013-03-10 23:00 ` Daniel Colascione
2013-03-11 9:51 ` Ken Brown
2013-03-09 12:16 ` Ken Brown
2013-03-09 19:31 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83txoly5ov.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13907@debbugs.gnu.org \
--cc=dancol@dancol.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.