From: Eli Zaretskii <eliz@gnu.org>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: 13935@debbugs.gnu.org
Subject: bug#13935: 24.3.50; `fullscreen' frame parameter is wrong, on MS Windows at least
Date: Fri, 15 Mar 2013 15:53:40 +0200 [thread overview]
Message-ID: <83txoc4vmj.fsf@gnu.org> (raw)
In-Reply-To: <625B5FFD-DB0D-4137-B022-35419E095A74@swipnet.se>
> Cc: Dani Moncayo <dmoncayo@gmail.com>,
> "drew.adams@oracle.com" <drew.adams@oracle.com>,
> "13935@debbugs.gnu.org" <13935@debbugs.gnu.org>
> From: Jan Djärv <jan.h.d@swipnet.se>
> Date: Fri, 15 Mar 2013 13:00:27 +0100
>
> > This was because the 'fullboth' terminology is confusing and tricked
> > me into thinking that 'fullboth' value of the 'fullscreen' frame
> > parameter means 'fullwidth' and 'fullheight' together. But in fact,
> > 'maximized' is 'fullwidth' and 'fullheight' together, while 'fullboth'
> > means the same as 'fullscreen'. Confusing.
> >
>
> In early versions of the EWMH-specification, there was no fullscreen. So when both maximize_width an maximize_height where set, windowmanagers did not know if to do fullscreen or maximized. I guess I used a WM that did fullscreen when I wrote this.
My problem was not with how we tell the WM to go full-screen. My
problem was with the Lisp symbols used for the possible values of this
frame parameter, and with their equivalent C enumeration values.
E.g., this code in frame.c:
if (NILP (new_value))
f->want_fullscreen = FULLSCREEN_NONE;
else if (EQ (new_value, Qfullboth) || EQ (new_value, Qfullscreen))
f->want_fullscreen = FULLSCREEN_BOTH;
else if (EQ (new_value, Qfullwidth))
f->want_fullscreen = FULLSCREEN_WIDTH;
else if (EQ (new_value, Qfullheight))
f->want_fullscreen = FULLSCREEN_HEIGHT;
else if (EQ (new_value, Qmaximized))
f->want_fullscreen = FULLSCREEN_MAXIMIZED;
FULLSCREEN_BOTH is clearly hinting that it is both FULLSCREEN_HEIGHT
and FULLSCREEN_WIDTH, while FULLSCREEN_MAXIMIZED is the odd one out.
But in fact, it's FULLSCREEN_BOTH that's the odd one out, and on the
Lisp level 'fullboth' and 'fullscreen' are synonyms. That's what
confused me: the semantics of these values, and their counter-mnemonic
nature.
next prev parent reply other threads:[~2013-03-15 13:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 20:44 bug#13935: 24.3.50; `fullscreen' frame parameter is wrong, on MS Windows at least Drew Adams
2013-03-12 21:25 ` Eli Zaretskii
2013-03-12 21:59 ` Drew Adams
2013-03-15 8:30 ` Eli Zaretskii
2013-03-15 9:24 ` Dani Moncayo
2013-03-15 10:12 ` Eli Zaretskii
2013-03-15 10:26 ` Dani Moncayo
2013-03-15 13:07 ` Stefan Monnier
2013-03-15 13:48 ` Eli Zaretskii
2013-03-15 17:54 ` Stefan Monnier
2013-03-15 12:00 ` Jan Djärv
2013-03-15 13:53 ` Eli Zaretskii [this message]
2013-03-15 18:32 ` Jan Djärv
2013-03-15 15:17 ` Drew Adams
2013-03-15 15:17 ` Drew Adams
2013-03-15 15:15 ` Drew Adams
2013-03-15 15:41 ` Eli Zaretskii
2013-03-23 9:34 ` Eli Zaretskii
2013-03-23 15:11 ` Drew Adams
2013-03-23 15:39 ` Eli Zaretskii
2013-03-12 22:38 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83txoc4vmj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13935@debbugs.gnu.org \
--cc=jan.h.d@swipnet.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.