From: Eli Zaretskii <eliz@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 14901@debbugs.gnu.org, angelo.graziosi@alice.it
Subject: bug#14901: Trunk bootstrap broken
Date: Fri, 19 Jul 2013 14:02:07 +0300 [thread overview]
Message-ID: <83txjqzuc0.fsf@gnu.org> (raw)
In-Reply-To: <CAAeL0SSfOZ3Uj_Gc_KYTnt-ELuqPgdh4nCF_CkN+5FpwW2_prA@mail.gmail.com>
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Fri, 19 Jul 2013 01:17:13 +0200
> Cc: 14901@debbugs.gnu.org
>
> > After Paul's changes, rev. 113451 bootstraps... Thanks.
>
> Yes, I just saw. Wonderful.
Not so wonderful. (Doesn't anyone watch compiler warnings these
days?) Using this:
struct x_display_info *di;
on anything but X11 is a no-no, since that struct is not portable.
The portable way is to use Display_Info, which a type defined on any
platform we support (including TTYs and even MS-DOS). No need for the
DISPLAY_INFO macro, either.
> But in ay case, could you please test that it works by changing WINDOWSNT
> to HAVE_NTGUI in that #ifdef? I think it's the right test anyway.
This whole rigmarole with multiple HAVE_* is not needed at all, since
HAVE_WINDOW_SYSTEM captures all of them.
I fixed both of the above in trunk revision 113456. I've verified
this to compile on GNU/Linux and on MS-Windows, I expect the NS port
will build without any problems, too.
next prev parent reply other threads:[~2013-07-19 11:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 20:07 bug#14901: Trunk bootstrap broken Angelo Graziosi
2013-07-18 20:24 ` Juanma Barranquero
2013-07-18 21:09 ` Angelo Graziosi
2013-07-18 21:45 ` Jan Djärv
2013-07-18 23:02 ` Juanma Barranquero
2013-07-18 23:13 ` Juanma Barranquero
2013-07-18 22:19 ` Angelo Graziosi
2013-07-18 23:17 ` Juanma Barranquero
2013-07-19 9:54 ` Angelo Graziosi
2013-07-19 9:58 ` Juanma Barranquero
2013-07-19 11:02 ` Eli Zaretskii [this message]
2013-07-19 11:38 ` Juanma Barranquero
2013-07-19 12:18 ` Angelo Graziosi
2013-07-19 13:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83txjqzuc0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=14901@debbugs.gnu.org \
--cc=angelo.graziosi@alice.it \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.